You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
NoteSyncRecord is no longer bounded due to the recent addition of note attachments
We could instead send just a note metadata "header", users can request the attachments via the notes endpoint
We need to design a cohesive (and sensible) schema change here which either aligns the gRPC definitions with the protocols, or name things differently so that its not confusing. The former seems ideal, but this may result in excess data that isn't technically required - or just be painful to get.
As per #1593 (comment), we have some issues with our
SyncTransactionsendpoint.TransactionHeadergRPC definition does not map to the protocol definitionTransactionIdfrom our gRPC response (original issue Addtransaction_idfield toTransactionRecord#1272)NoteSyncRecordis no longer bounded due to the recent addition of note attachmentsWe need to design a cohesive (and sensible) schema change here which either aligns the gRPC definitions with the protocols, or name things differently so that its not confusing. The former seems ideal, but this may result in excess data that isn't technically required - or just be painful to get.
Supersedes #1272