More user control over plugin execution

[joshuarli]

"Once installed, this plugin will automatically execute editorconfig.getApplyProperties on files when they are opened or saved."

So this is a pretty sane default IMO, but some users may want to configure it so that execution is disabled on file open and file save, so that a custom keybinding can be configured for plugin execution.

How should we go about implementing this @10sr? settings.json?

[10sr]

I do not have any strong opinion for this.
I thinks there can be several ways to achieve this, for example following two options: IMO either way is OK !

• Add two config boolean options: somethinkg like editorconfigdisableonsave and editorconfigdisableonopen
• Add a option like editorconfigapplywhen, whose value should be an array and defaults to ["onSave", "onSave"]

[joshuarli]

I like the two disable boolean options, because they reflect that there are sane defaults yet the end user can choose to disable them in favor of a keybinding. I'll get around to implementing this when I have some time.