From 8ed50058cc850014491412b334c7ea6a70407e4c Mon Sep 17 00:00:00 2001 From: Darby Johnston Date: Tue, 24 Mar 2026 11:45:39 -0700 Subject: [PATCH 1/2] Fix various warnings Signed-off-by: Darby Johnston --- CMakeLists.txt | 2 ++ MANIFEST.in | 26 +------------------------ src/opentimelineio/serializableObject.h | 2 +- 3 files changed, 4 insertions(+), 26 deletions(-) diff --git a/CMakeLists.txt b/CMakeLists.txt index 1d2b233ef..e56177348 100644 --- a/CMakeLists.txt +++ b/CMakeLists.txt @@ -1,6 +1,8 @@ # FindPython's Development.Module component was added in 3.18. # Require 3.18.2+ because pybind11 recommends it. cmake_minimum_required(VERSION 3.18.2) +# This policy CMP0177 can be removed when we upgrade to CMake >= 3.31. +cmake_policy(SET CMP0177 NEW) #------------------------------------------------------------------------------ # Project Metadata diff --git a/MANIFEST.in b/MANIFEST.in index 7507decb8..d17c5e7fe 100644 --- a/MANIFEST.in +++ b/MANIFEST.in @@ -1,32 +1,8 @@ -include README.md README_contrib.md CHANGELOG.md LICENSE.txt NOTICE.txt SECURITY.md CMakeLists.txt +include README.md README_contrib.md LICENSE.txt NOTICE.txt SECURITY.md CMakeLists.txt recursive-include examples * recursive-include src * recursive-include tests * -prune .github -prune docs -prune doxygen -exclude .gitmodules -recursive-exclude src *.git -exclude .readthedocs.yml -exclude readthedocs-conda.yml -exclude .codecov.yml -exclude .gitlab-ci.yml -exclude *.pdf -exclude ADOPTERS.md -exclude CODE_OF_CONDUCT.md -exclude CONTRIBUTING.md -exclude CONTRIBUTORS.md -exclude GOVERNANCE.md -exclude VERSIONS.md -exclude Makefile exclude */.DS_Store -exclude .clang-format -exclude OTIO_VERSION.json global-exclude *.pyc -global-exclude *.so global-exclude *.pyd - -prune maintainers -prune tsc -prune src/deps/pybind11/tools/clang prune src/deps/rapidjson/thirdparty diff --git a/src/opentimelineio/serializableObject.h b/src/opentimelineio/serializableObject.h index 118e686fd..8a97110ae 100644 --- a/src/opentimelineio/serializableObject.h +++ b/src/opentimelineio/serializableObject.h @@ -162,7 +162,7 @@ class OTIO_API_TYPE SerializableObject template bool read(std::string const& key, Retainer* dest) { - SerializableObject* so; + SerializableObject* so = nullptr; if (!read(key, &so)) { return false; From 3bceab367d29c741c7f400bd561673e4d6c2c679 Mon Sep 17 00:00:00 2001 From: Darby Johnston Date: Tue, 24 Mar 2026 12:18:13 -0700 Subject: [PATCH 2/2] Revert changes Signed-off-by: Darby Johnston --- MANIFEST.in | 26 +++++++++++++++++++++++++- 1 file changed, 25 insertions(+), 1 deletion(-) diff --git a/MANIFEST.in b/MANIFEST.in index d17c5e7fe..7507decb8 100644 --- a/MANIFEST.in +++ b/MANIFEST.in @@ -1,8 +1,32 @@ -include README.md README_contrib.md LICENSE.txt NOTICE.txt SECURITY.md CMakeLists.txt +include README.md README_contrib.md CHANGELOG.md LICENSE.txt NOTICE.txt SECURITY.md CMakeLists.txt recursive-include examples * recursive-include src * recursive-include tests * +prune .github +prune docs +prune doxygen +exclude .gitmodules +recursive-exclude src *.git +exclude .readthedocs.yml +exclude readthedocs-conda.yml +exclude .codecov.yml +exclude .gitlab-ci.yml +exclude *.pdf +exclude ADOPTERS.md +exclude CODE_OF_CONDUCT.md +exclude CONTRIBUTING.md +exclude CONTRIBUTORS.md +exclude GOVERNANCE.md +exclude VERSIONS.md +exclude Makefile exclude */.DS_Store +exclude .clang-format +exclude OTIO_VERSION.json global-exclude *.pyc +global-exclude *.so global-exclude *.pyd + +prune maintainers +prune tsc +prune src/deps/pybind11/tools/clang prune src/deps/rapidjson/thirdparty