From af5021dab4356acfcb7332451d328bd5422aaea8 Mon Sep 17 00:00:00 2001 From: GuustMetz Date: Wed, 1 Apr 2026 17:06:41 +0200 Subject: [PATCH 1/3] fix: make name childeren flex-row --- .../views/Runs/RunPerPeriod/RunsPerLhcPeriodOverviewPage.js | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/lib/public/views/Runs/RunPerPeriod/RunsPerLhcPeriodOverviewPage.js b/lib/public/views/Runs/RunPerPeriod/RunsPerLhcPeriodOverviewPage.js index f4e0895e4c..c5ada5d8a7 100644 --- a/lib/public/views/Runs/RunPerPeriod/RunsPerLhcPeriodOverviewPage.js +++ b/lib/public/views/Runs/RunPerPeriod/RunsPerLhcPeriodOverviewPage.js @@ -29,6 +29,7 @@ import { filtersPanelPopover } from '../../../components/Filters/common/filtersP import { runNumbersFilter } from '../../../components/Filters/RunsFilter/runNumbersFilter.js'; import { mcReproducibleAsNotBadToggle } from '../mcReproducibleAsNotBadToggle.js'; import { exportTriggerAndModal } from '../../../components/common/dataExport/exportTriggerAndModal.js'; +import { breadcrumbs } from '../../../components/common/navigation/breadcrumbs.js'; const TABLEROW_HEIGHT = 62; // Estimate of the navbar and pagination elements height total; Needs to be updated in case of changes; @@ -109,7 +110,7 @@ export const RunsPerLhcPeriodOverviewPage = ({ runs: { perLhcPeriodOverviewModel h('.flex-row.justify-between.items-center.g2', [ filtersPanelPopover(perLhcPeriodOverviewModel, activeColumns, { profile: 'runsPerLhcPeriod' }), h('.pl2#runOverviewFilter', runNumbersFilter(perLhcPeriodOverviewModel.filteringModel.get('runNumbers'))), - h('h2', ['Good physics runs of ', lhcPeriodName]), + h('h2.flex-row', ['Good physics runs of ', lhcPeriodName]), mcReproducibleAsNotBadToggle( mcReproducibleAsNotBad, () => perLhcPeriodOverviewModel.setMcReproducibleAsNotBad(!mcReproducibleAsNotBad), From a23f0ac1a68d68541db59df45f9bfef47da257ea Mon Sep 17 00:00:00 2001 From: GuustMetz Date: Wed, 1 Apr 2026 17:10:30 +0200 Subject: [PATCH 2/3] remove breadcrumbs import --- .../views/Runs/RunPerPeriod/RunsPerLhcPeriodOverviewPage.js | 1 - 1 file changed, 1 deletion(-) diff --git a/lib/public/views/Runs/RunPerPeriod/RunsPerLhcPeriodOverviewPage.js b/lib/public/views/Runs/RunPerPeriod/RunsPerLhcPeriodOverviewPage.js index c5ada5d8a7..57cabd800e 100644 --- a/lib/public/views/Runs/RunPerPeriod/RunsPerLhcPeriodOverviewPage.js +++ b/lib/public/views/Runs/RunPerPeriod/RunsPerLhcPeriodOverviewPage.js @@ -29,7 +29,6 @@ import { filtersPanelPopover } from '../../../components/Filters/common/filtersP import { runNumbersFilter } from '../../../components/Filters/RunsFilter/runNumbersFilter.js'; import { mcReproducibleAsNotBadToggle } from '../mcReproducibleAsNotBadToggle.js'; import { exportTriggerAndModal } from '../../../components/common/dataExport/exportTriggerAndModal.js'; -import { breadcrumbs } from '../../../components/common/navigation/breadcrumbs.js'; const TABLEROW_HEIGHT = 62; // Estimate of the navbar and pagination elements height total; Needs to be updated in case of changes; From 7d2161aa97e332db236e5c68a265dfc9b657b02f Mon Sep 17 00:00:00 2001 From: Isaac Hill <71404865+isaachilly@users.noreply.github.com> Date: Wed, 1 Apr 2026 19:22:33 +0200 Subject: [PATCH 3/3] [O2B-1575] Add missing comma --- .../views/Runs/RunPerPeriod/RunsPerLhcPeriodOverviewPage.js | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/lib/public/views/Runs/RunPerPeriod/RunsPerLhcPeriodOverviewPage.js b/lib/public/views/Runs/RunPerPeriod/RunsPerLhcPeriodOverviewPage.js index 57cabd800e..5c6134e6be 100644 --- a/lib/public/views/Runs/RunPerPeriod/RunsPerLhcPeriodOverviewPage.js +++ b/lib/public/views/Runs/RunPerPeriod/RunsPerLhcPeriodOverviewPage.js @@ -109,7 +109,7 @@ export const RunsPerLhcPeriodOverviewPage = ({ runs: { perLhcPeriodOverviewModel h('.flex-row.justify-between.items-center.g2', [ filtersPanelPopover(perLhcPeriodOverviewModel, activeColumns, { profile: 'runsPerLhcPeriod' }), h('.pl2#runOverviewFilter', runNumbersFilter(perLhcPeriodOverviewModel.filteringModel.get('runNumbers'))), - h('h2.flex-row', ['Good physics runs of ', lhcPeriodName]), + h('h2.flex-row', ['Good, physics runs of ', lhcPeriodName]), mcReproducibleAsNotBadToggle( mcReproducibleAsNotBad, () => perLhcPeriodOverviewModel.setMcReproducibleAsNotBad(!mcReproducibleAsNotBad),