Skip to content

Commit a4635f3

Browse files
jokonigjokonig
andauthored
[EMCAL-519] Add protection to not override bad qualitiy with medium (#2658)
- If there are several errors present, the Medium quality can override the Bad quality. This should not happen and hence a protection is added Co-authored-by: jokonig <jokonig@cern.ch>
1 parent 9396c9c commit a4635f3

File tree

1 file changed

+1
-1
lines changed

1 file changed

+1
-1
lines changed

Modules/EMCAL/src/RawErrorCheck.cxx

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -271,7 +271,7 @@ Quality RawErrorCheck::check(std::map<std::string, std::shared_ptr<MonitorObject
271271
}
272272
result.addFlag(FlagTypeFactory::Unknown(), "Raw error " + std::string(errorhist->GetYaxis()->GetBinLabel(errorcode + 1)) + " above critical threshold: Call oncall!");
273273

274-
} else if (numErrors > thresholdTotalErrWarn) { // Number of raw error exceeds the threshold but is considered to be okay. Error can be fixed at beam dump
274+
} else if (numErrors > thresholdTotalErrWarn && result != Quality::Bad) { // Number of raw error exceeds the threshold but is considered to be okay. Error can be fixed at beam dump
275275
if (result != Quality::Medium) {
276276
result = Quality::Medium;
277277
}

0 commit comments

Comments
 (0)