refactor: make transaction methods protected (#166)

Author: alexbarnsley

crypto/transactions/types/abstract_transaction.py

@@ -41,7 +41,7 @@ def get_public_key(self, compact_signature, hash_):
         return public_key
 
     def recover_sender(self):
-        signature_with_recid = self.get_signature()
+        signature_with_recid = self._get_signature()
         if not signature_with_recid:
             return False
 
@@ -51,7 +51,7 @@ def recover_sender(self):
         self.data['senderAddress'] = Address.from_public_key(self.data['senderPublicKey'])
 
     def verify(self) -> bool:
-        signature_with_recid = self.get_signature()
+        signature_with_recid = self._get_signature()
         if not signature_with_recid:
             return False
 
@@ -79,7 +79,7 @@ def to_json(self) -> str:
     def hash(self, skip_signature: bool) -> str:
         return TransactionUtils.to_hash(self.data, skip_signature=skip_signature)
 
-    def get_signature(self):
+    def _get_signature(self):
         recover_id = int(self.data.get('v', 0)) - Constants.ETHEREUM_RECOVERY_ID_OFFSET.value
         r = self.data.get('r')
         s = self.data.get('s')
@@ -90,7 +90,7 @@ def get_signature(self):
         return None
 
     @staticmethod
-    def decode_payload(data: dict, abi_type: ContractAbiType = ContractAbiType.CONSENSUS) -> Optional[dict]:
+    def _decode_payload(data: dict, abi_type: ContractAbiType = ContractAbiType.CONSENSUS) -> Optional[dict]:
         from crypto.transactions.deserializer import Deserializer
 
         return Deserializer.decode_payload(data, abi_type)

crypto/transactions/types/multipayment.py

@@ -6,7 +6,7 @@
 
 class Multipayment(AbstractTransaction):
     def __init__(self, data: dict):
-        payload = self.decode_payload(data, ContractAbiType.MULTIPAYMENT)
+        payload = self._decode_payload(data, ContractAbiType.MULTIPAYMENT)
         if payload:
             data['pay'] = payload.get('args', [])
 

crypto/transactions/types/username_registration.py

@@ -6,7 +6,7 @@
 
 class UsernameRegistration(AbstractTransaction):
     def __init__(self, data: dict):
-        payload = self.decode_payload(data, ContractAbiType.USERNAMES)
+        payload = self._decode_payload(data, ContractAbiType.USERNAMES)
         if payload:
             data['username'] = payload.get('args', [None])[0] if payload.get('args') else None
 

crypto/transactions/types/validator_registration.py

@@ -6,9 +6,10 @@
 
 class ValidatorRegistration(AbstractTransaction):
     def __init__(self, data: dict):
-        payload = self.decode_payload(data)
+        payload = self._decode_payload(data)
         if payload:
             data['validatorPublicKey'] = TransactionUtils.parse_hex_from_str(payload.get('args', [None])[0]) if payload.get('args') else None
+
         super().__init__(data)
 
     def get_payload(self) -> str:

crypto/transactions/types/vote.py

@@ -5,7 +5,7 @@
 
 class Vote(AbstractTransaction):
     def __init__(self, data: dict):
-        payload = self.decode_payload(data)
+        payload = self._decode_payload(data)
         if payload:
             data['vote'] = payload.get('args', [None])[0] if payload.get('args') else None