-
Notifications
You must be signed in to change notification settings - Fork 130
Description
Currently, our lookup tables (as a part of ultra-plonk) are pre-computed once for every execution. Ideally we should only ever pre-compute our lookup tables once. Note that even though lookup tables don't need to be static for UltraPlonk, pre-computing them on every run can become time-consuming if we support larger tables. Further, the way we avoid repeated pre-computation using the variable inited is error prone.
For example, with Pedersen hash using lookup tables, if we fill up the tables during compile-time (we don't disallow such cases), then the variable inited is true when we start the execution but the actual tables are empty. Such things can lead to subtle bugs and cost us a lot of programming time. It will be nice to implement static lookup tables instead.