Minor items from PR #7630 review, none blocking.
-
case-sensitive swap vs case-insensitive deploy — swap's isValidSlotName uses slices.Contains (exact match), deploy uses strings.EqualFold. Align swap with slices.ContainsFunc + strings.EqualFold.
-
@production undocumented — normalizeSlotName accepts @production but flag help only mentions production. Add a note.
-
deploy loop over single-element slice — determineDeploymentTargets now always returns one target. Simplify the loop in Deploy().
-
add case-insensitive slot name test — have test for Production → main app, but not Staging → staging slot. Add one.
Ref: #7365, #7630
Minor items from PR #7630 review, none blocking.
case-sensitive swap vs case-insensitive deploy — swap's
isValidSlotNameusesslices.Contains(exact match), deploy usesstrings.EqualFold. Align swap withslices.ContainsFunc+strings.EqualFold.@productionundocumented —normalizeSlotNameaccepts@productionbut flag help only mentionsproduction. Add a note.deploy loop over single-element slice —
determineDeploymentTargetsnow always returns one target. Simplify the loop inDeploy().add case-insensitive slot name test — have test for
Production→ main app, but notStaging→stagingslot. Add one.Ref: #7365, #7630