Skip to content

Azure Storage STG 102 Features #6982

@Jinming-Hu

Description

@Jinming-Hu

test cases to enable before GA release:

156 - azure-storage-blobs.BlockBlobClientTest.RehydrateTierToSmart (Failed)
191 - azure-storage-blobs.BlockBlobClientTest.SmartTier (Failed)
375 - azure-storage-files-datalake.DataLakePathClientTest.GetSetTags (Failed)

and below test cases:

diff --git a/sdk/storage/azure-storage-files-datalake/test/ut/datalake_sas_test.cpp b/sdk/storage/azure-storage-files-datalake/test/ut/datalake_sas_test.cpp
index 0670e8530..d5e3458c5 100644
--- a/sdk/storage/azure-storage-files-datalake/test/ut/datalake_sas_test.cpp
+++ b/sdk/storage/azure-storage-files-datalake/test/ut/datalake_sas_test.cpp
@@ -120,6 +120,16 @@ namespace Azure { namespace Storage { namespace Test {
       auto acls = pathClient.GetAccessControlList().Value.Acls;
       EXPECT_NO_THROW(pathClient1.SetAccessControlList(acls));
     }
+
+    void VerifyDataLakeSasTags(
+        const Files::DataLake::DataLakePathClient& pathClient,
+        const std::string& sasToken)
+    {
+      auto pathClient1 = GetSasAuthenticatedClient(pathClient, sasToken);
+      const std::map<std::string, std::string> tags = {{"k1" , "v1"}};
+      EXPECT_NO_THROW(pathClient1.SetTags(tags));
+      EXPECT_NO_THROW(pathClient1.GetTags());
+    }
   };
 
   TEST_F(DataLakeSasTest, AccountSasPermissions_LIVEONLY_)
@@ -228,6 +238,7 @@ namespace Azure { namespace Storage { namespace Test {
              Sas::DataLakeSasPermissions::Move,
              Sas::DataLakeSasPermissions::Execute,
              Sas::DataLakeSasPermissions::ManageAccessControl,
+             Sas::DataLakeSasPermissions::Tags,
          })
     {
       fileSystemSasBuilder.SetPermissions(permissions);
@@ -276,6 +287,11 @@ namespace Azure { namespace Storage { namespace Test {
         VerifyDataLakeSasManageAccessControl(dataLakeDirectoryClient, sasToken);
         VerifyDataLakeSasManageAccessControl(dataLakeDirectoryClient, sasToken2);
       }
+      if ((permissions & Sas::DataLakeSasPermissions::Tags) == Sas::DataLakeSasPermissions::Tags)
+      {
+        VerifyDataLakeSasTags(dataLakeFileClient, sasToken);
+        VerifyDataLakeSasTags(dataLakeFileClient, sasToken2);
+      }
     }
   }
 
@@ -313,6 +329,7 @@ namespace Azure { namespace Storage { namespace Test {
              Sas::DataLakeSasPermissions::Create,
              Sas::DataLakeSasPermissions::Execute,
              Sas::DataLakeSasPermissions::ManageAccessControl,
+             Sas::DataLakeSasPermissions::Tags,
          })
     {
       fileSasBuilder.SetPermissions(permissions);
@@ -351,6 +368,11 @@ namespace Azure { namespace Storage { namespace Test {
         VerifyDataLakeSasManageAccessControl(dataLakeFileClient, sasToken);
         VerifyDataLakeSasManageAccessControl(dataLakeFileClient, sasToken2);
       }
+      if ((permissions & Sas::DataLakeSasPermissions::Tags) == Sas::DataLakeSasPermissions::Tags)
+      {
+        VerifyDataLakeSasTags(dataLakeFileClient, sasToken);
+        VerifyDataLakeSasTags(dataLakeFileClient, sasToken2);
+      }
     }
   }
 
@@ -390,6 +412,7 @@ namespace Azure { namespace Storage { namespace Test {
              Sas::DataLakeSasPermissions::Create,
              Sas::DataLakeSasPermissions::Execute,
              Sas::DataLakeSasPermissions::ManageAccessControl,
+             Sas::DataLakeSasPermissions::Tags,
          })
     {
       directorySasBuilder.SetPermissions(permissions);
@@ -417,6 +440,10 @@ namespace Azure { namespace Storage { namespace Test {
       {
         VerifyDataLakeSasManageAccessControl(dataLakeDirectoryClient, sasToken2);
       }
+      if ((permissions & Sas::DataLakeSasPermissions::Tags) == Sas::DataLakeSasPermissions::Tags)
+      {
+        VerifyDataLakeSasTags(dataLakeDirectoryClient, sasToken2);
+      }
     }
   }

Metadata

Metadata

Assignees

Labels

ClientThis issue points to a problem in the data-plane of the library.StorageStorage Service (Queues, Blobs, Files)

Projects

No projects

Milestone

No milestone

Relationships

None yet

Development

No branches or pull requests

Issue actions