Fixed bug where calling "pop" from growable lists can sometimes yield incorrect value due to resizing

Author: AzureTriple

lib/src/main/java/azuretriple/primitivecontainer/ByteList.java

@@ -61,7 +61,7 @@ default void insert(final int location,final byte[] v,final int start,final int
     /** Removes the value at the specified location from the list. */
     void remove(final int location);
     /** Removes and returns the last value from the list. */
-    default byte pop() {delete(); return data()[((List)this).size];}
+    default byte pop() {final byte out = data()[((List)this).size-1]; delete(); return out;}
     /** Removes and returns the value at the specified location from the list. */
     default byte extract(final int location) {final byte o = data()[location]; remove(location); return o;}
 

lib/src/main/java/azuretriple/primitivecontainer/DoubleList.java

@@ -61,7 +61,7 @@ default void insert(final int location,final double[] v,final int start,final in
     /** Removes the value at the specified location from the list. */
     void remove(final int location);
     /** Removes and returns the last value from the list. */
-    default double pop() {delete(); return data()[((List)this).size];}
+    default double pop() {final double out = data()[((List)this).size-1]; delete(); return out;}
     /** Removes and returns the value at the specified location from the list. */
     default double extract(final int location) {final double o = data()[location]; remove(location); return o;}
 

lib/src/main/java/azuretriple/primitivecontainer/FloatList.java

@@ -61,7 +61,7 @@ default void insert(final int location,final float[] v,final int start,final int
     /** Removes the value at the specified location from the list. */
     void remove(final int location);
     /** Removes and returns the last value from the list. */
-    default float pop() {delete(); return data()[((List)this).size];}
+    default float pop() {final float out = data()[((List)this).size-1]; delete(); return out;}
     /** Removes and returns the value at the specified location from the list. */
     default float extract(final int location) {final float o = data()[location]; remove(location); return o;}
 

lib/src/main/java/azuretriple/primitivecontainer/IntList.java

@@ -61,7 +61,7 @@ default void insert(final int location,final int[] v,final int start,final int l
     /** Removes the value at the specified location from the list. */
     void remove(final int location);
     /** Removes and returns the last value from the list. */
-    default int pop() {delete(); return data()[((List)this).size];}
+    default int pop() {final int out = data()[((List)this).size-1]; delete(); return out;}
     /** Removes and returns the value at the specified location from the list. */
     default int extract(final int location) {final int o = data()[location]; remove(location); return o;}
 

lib/src/main/java/azuretriple/primitivecontainer/LongList.java

@@ -61,7 +61,7 @@ default void insert(final int location,final long[] v,final int start,final int
     /** Removes the value at the specified location from the list. */
     void remove(final int location);
     /** Removes and returns the last value from the list. */
-    default long pop() {delete(); return data()[((List)this).size];}
+    default long pop() {final long out = data()[((List)this).size-1]; delete(); return out;}
     /** Removes and returns the value at the specified location from the list. */
     default long extract(final int location) {final long o = data()[location]; remove(location); return o;}
 

lib/src/main/java/azuretriple/primitivecontainer/ShortList.java

@@ -61,7 +61,7 @@ default void insert(final int location,final short[] v,final int start,final int
     /** Removes the value at the specified location from the list. */
     void remove(final int location);
     /** Removes and returns the last value from the list. */
-    default short pop() {delete(); return data()[((List)this).size];}
+    default short pop() {final short out = data()[((List)this).size-1]; delete(); return out;}
     /** Removes and returns the value at the specified location from the list. */
     default short extract(final int location) {final short o = data()[location]; remove(location); return o;}
 

lib/src/test/java/azuretriple/primitivecontainer/GrowableByteListTest.java

@@ -66,4 +66,12 @@ void testClone()
         final GrowableByteList l = new GrowableByteList(new byte[] {0,1,2,3},2);
         assertEquals(l,l.clone());
     }
+    
+    @Test
+    void testPop()
+    {
+        final GrowableByteList l = new GrowableByteList(16);
+        l.add((byte)1);
+        assertEquals((byte)1,l.pop());
+    }
 }

lib/src/test/java/azuretriple/primitivecontainer/GrowableDoubleListTest.java

@@ -66,4 +66,12 @@ void testClone()
         final GrowableDoubleList l = new GrowableDoubleList(new double[] {0,1,2,3},2);
         assertEquals(l,l.clone());
     }
+    
+    @Test
+    void testPop()
+    {
+        final GrowableDoubleList l = new GrowableDoubleList(16);
+        l.add(1.D);
+        assertEquals(1.D,l.pop());
+    }
 }

lib/src/test/java/azuretriple/primitivecontainer/GrowableFloatListTest.java

@@ -66,4 +66,12 @@ void testClone()
         final GrowableFloatList l = new GrowableFloatList(new float[] {0,1,2,3},2);
         assertEquals(l,l.clone());
     }
+    
+    @Test
+    void testPop()
+    {
+        final GrowableFloatList l = new GrowableFloatList(16);
+        l.add(1.F);
+        assertEquals(1.F,l.pop());
+    }
 }

lib/src/test/java/azuretriple/primitivecontainer/GrowableIntListTest.java

@@ -66,4 +66,12 @@ void testClone()
         final GrowableIntList l = new GrowableIntList(new int[] {0,1,2,3},2);
         assertEquals(l,l.clone());
     }
+    
+    @Test
+    void testPop()
+    {
+        final GrowableIntList l = new GrowableIntList(16);
+        l.add(1);
+        assertEquals(1,l.pop());
+    }
 }