Skip to content

Commit 7cd76fc

Browse files
Merge pull request #8053 from BitGo/BTC-3003.remove-depcheck
feat(workflows): remove dependency audit from PR checks
2 parents 8e3d18f + 3716997 commit 7cd76fc

2 files changed

Lines changed: 6 additions & 4 deletions

File tree

.github/workflows/ci.yml

Lines changed: 3 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -87,7 +87,7 @@ jobs:
8787
strategy:
8888
fail-fast: false
8989
matrix:
90-
check: ['lint', 'format', 'commit-lint', 'dependencies', 'audit']
90+
check: ['lint', 'format', 'commit-lint', 'dependencies']
9191

9292
steps:
9393
- uses: actions/checkout@11bd71901bbe5b1630ceea73d27597364c9af683 # v4.2.2
@@ -130,9 +130,8 @@ jobs:
130130
if: matrix.check == 'dependencies'
131131
run: yarn run check-deps
132132

133-
- name: Audit Dependencies
134-
if: matrix.check == 'audit'
135-
run: yarn run improved-yarn-audit --min-severity high
133+
# We conciously do not audit dependencies as a PR step since errors are typically
134+
# unrelated to the PR changes. This check is performed in `publish.yml`.
136135

137136
license-analysis:
138137
runs-on: ubuntu-latest

.github/workflows/publish.yml

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -28,6 +28,9 @@ jobs:
2828
- name: Install BitGoJS
2929
run: yarn install --with-frozen-lockfile
3030

31+
- name: Audit Dependencies
32+
run: yarn run improved-yarn-audit --min-severity high
33+
3134
- name: Set Environment Variable for Alpha
3235
if: github.ref != 'refs/heads/master' # only publish changes if on feature branches
3336
run: |

0 commit comments

Comments
 (0)