feat(abstract-utxo): use coin name instead of network to determine chain

Refactor chain determination to use coin name instead of deprecated
direct network usage. This approach is more consistent and avoids
accessing internal network objects directly.

Issue: BTC-2916

Co-authored-by: llm-git <llm-git@ttll.de>

Author: OttoAllmendinger

modules/abstract-utxo/test/unit/coins.ts

@@ -2,14 +2,19 @@ import * as assert from 'assert';
 
 import * as utxolib from '@bitgo/utxo-lib';
 
-import { getMainnetCoinName, utxoCoinsMainnet, utxoCoinsTestnet } from '../../src/names';
+import { getMainnetCoinName, getNetworkFromCoinName, utxoCoinsMainnet, utxoCoinsTestnet } from '../../src/names';
 
 import { getUtxoCoinForNetwork, utxoCoins } from './util';
 
 describe('utxoCoins', function () {
   it('has expected chain/network values for items', function () {
     assert.deepStrictEqual(
-      utxoCoins.map((c) => [c.getChain(), c.getFamily(), c.getFullName(), utxolib.getNetworkName(c.network)]),
+      utxoCoins.map((c) => [
+        c.getChain(),
+        c.getFamily(),
+        c.getFullName(),
+        utxolib.getNetworkName(getNetworkFromCoinName(c.name)),
+      ]),
       [
         ['btc', 'btc', 'Bitcoin', 'bitcoin'],
         ['tbtc', 'btc', 'Testnet Bitcoin', 'testnet'],

modules/abstract-utxo/test/unit/prebuildAndSign.ts

@@ -6,6 +6,7 @@ import { common, HalfSignedUtxoTransaction, Wallet } from '@bitgo/sdk-core';
 import { getSeed } from '@bitgo/sdk-test';
 
 import { AbstractUtxoCoin, getReplayProtectionAddresses } from '../../src';
+import { getMainnetCoinName } from '../../src/names';
 
 import { defaultBitGo, encryptKeychain, getDefaultWalletKeys, getUtxoWallet, keychainsBase58, utxoCoins } from './util';
 
@@ -295,7 +296,7 @@ function run(coin: AbstractUtxoCoin, inputScripts: ScriptType[], txFormat: TxFor
 }
 
 utxoCoins
-  .filter((coin) => utxolib.getMainnet(coin.network) !== utxolib.networks.bitcoinsv)
+  .filter((coin) => getMainnetCoinName(coin.name) !== 'bsv')
   .forEach((coin) => {
     scriptTypes
       // Don't iterate over p2shP2pk - in no scenario would a wallet spend two p2shP2pk inputs as these

modules/abstract-utxo/test/unit/recovery/crossChainRecovery.ts

@@ -16,6 +16,7 @@ import {
   generateAddress,
   convertLtcAddressToLegacyFormat,
 } from '../../../src';
+import { isMainnetCoin, isTestnetCoin } from '../../../src/names';
 import {
   getFixture,
   keychainsBase58,
@@ -265,8 +266,8 @@ utxoCoins.forEach((coin) => {
       (otherCoin) =>
         coin !== otherCoin &&
         isSupportedCrossChainRecovery(coin, otherCoin) &&
-        ((utxolib.isMainnet(coin.network) && utxolib.isMainnet(otherCoin.network)) ||
-          (utxolib.isTestnet(coin.network) && utxolib.isTestnet(otherCoin.network)))
+        ((isMainnetCoin(coin.name) && isMainnetCoin(otherCoin.name)) ||
+          (isTestnetCoin(coin.name) && isTestnetCoin(otherCoin.name)))
     )
     .forEach((otherCoin) => {
       if (coin.amountType === 'bigint') {

modules/abstract-utxo/test/unit/txFormat.ts

@@ -1,9 +1,9 @@
 import * as assert from 'assert';
 
-import * as utxolib from '@bitgo/utxo-lib';
 import { Wallet } from '@bitgo/sdk-core';
 
 import { AbstractUtxoCoin, ErrorDeprecatedTxFormat, TxFormat } from '../../src';
+import { getMainnetCoinName, isMainnetCoin, isTestnetCoin } from '../../src/names';
 
 import { utxoCoins, defaultBitGo } from './util';
 
@@ -106,39 +106,38 @@ describe('txFormat', function () {
     // All testnet wallets default to PSBT-lite
     runTest({
       description: 'should always return psbt-lite for testnet',
-      coinFilter: (coin) => utxolib.isTestnet(coin.network),
+      coinFilter: (coin) => isTestnetCoin(coin.name),
       expectedTxFormat: 'psbt-lite',
     });
 
     // DistributedCustody wallets default to PSBT (mainnet only, testnet already covered)
     runTest({
       description: 'should return psbt for distributedCustody wallets on mainnet',
-      coinFilter: (coin) => utxolib.isMainnet(coin.network),
+      coinFilter: (coin) => isMainnetCoin(coin.name),
       walletFilter: (w) => w.options.subType === 'distributedCustody',
       expectedTxFormat: 'psbt',
     });
 
     // MuSig2 wallets default to PSBT (mainnet only, testnet already covered)
     runTest({
       description: 'should return psbt for wallets with musigKp flag on mainnet',
-      coinFilter: (coin) => utxolib.isMainnet(coin.network),
+      coinFilter: (coin) => isMainnetCoin(coin.name),
       walletFilter: (w) => Boolean(w.options.walletFlags?.some((f) => f.name === 'musigKp' && f.value === 'true')),
       expectedTxFormat: 'psbt',
     });
 
     // Mainnet Bitcoin hot wallets default to PSBT
     runTest({
       description: 'should return psbt for mainnet bitcoin hot wallets',
-      coinFilter: (coin) =>
-        utxolib.isMainnet(coin.network) && utxolib.getMainnet(coin.network) === utxolib.networks.bitcoin,
+      coinFilter: (coin) => isMainnetCoin(coin.name) && getMainnetCoinName(coin.name) === 'btc',
       walletFilter: (w) => w.options.type === 'hot',
       expectedTxFormat: 'psbt',
     });
 
     // Other mainnet wallets do NOT default to PSBT
     runTest({
       description: 'should return undefined for other mainnet wallets',
-      coinFilter: (coin) => utxolib.isMainnet(coin.network),
+      coinFilter: (coin) => isMainnetCoin(coin.name),
       walletFilter: (w) => {
         const isHotBitcoin = w.options.type === 'hot'; // This will be bitcoin hot wallets
         const isDistributedCustody = w.options.subType === 'distributedCustody';
@@ -152,7 +151,7 @@ describe('txFormat', function () {
     // Test explicitly requested formats
     runTest({
       description: 'should respect explicitly requested legacy format on mainnet',
-      coinFilter: (coin) => utxolib.isMainnet(coin.network),
+      coinFilter: (coin) => isMainnetCoin(coin.name),
       expectedTxFormat: 'legacy',
       requestedTxFormat: 'legacy',
     });
@@ -172,7 +171,7 @@ describe('txFormat', function () {
     // Test that legacy format is prohibited on testnet
     it('should throw ErrorDeprecatedTxFormat when legacy format is requested on testnet', function () {
       for (const coin of utxoCoins) {
-        if (!utxolib.isTestnet(coin.network)) {
+        if (!isTestnetCoin(coin.name)) {
           continue;
         }