Merge pull request #8492 from BitGo/CHALO-225-dydxcosmos-coin-family

feat(statics): add dydxcosmos coin family to distinguish from erc20 dydx

Author: abhijeet8986

modules/statics/src/allCoinsAndTokens.ts

@@ -1084,7 +1084,7 @@ export const allCoinsAndTokens = [
     'dYdX Cosmos',
     Networks.main.dydx,
     18,
-    UnderlyingAsset.DYDX,
+    UnderlyingAsset.DYDXCOSMOS,
     BaseUnit.DYDX,
     [...COSMOS_SIDECHAIN_FEATURES, CoinFeature.SHARED_COSMOS_SDK, CoinFeature.SHARED_COSMOS_WP]
   ),
@@ -1094,7 +1094,7 @@ export const allCoinsAndTokens = [
     'Testnet dYdX Cosmos',
     Networks.test.dydx,
     18,
-    UnderlyingAsset.DYDX,
+    UnderlyingAsset.DYDXCOSMOS,
     BaseUnit.DYDX,
     [...COSMOS_SIDECHAIN_FEATURES, CoinFeature.SHARED_COSMOS_SDK, CoinFeature.SHARED_COSMOS_WP]
   ),

modules/statics/src/base.ts

@@ -53,6 +53,7 @@ export enum CoinFamily {
   DOGEOS = 'dogeos',
   DOT = 'dot',
   DYDX = 'dydx',
+  DYDXCOSMOS = 'dydxcosmos',
   EOS = 'eos',
   ETC = 'etc',
   ETH = 'eth',
@@ -1033,6 +1034,7 @@ export enum UnderlyingAsset {
   DXPT = 'dxpt',
   DXST = 'dxst',
   DYDX = 'dydx',
+  DYDXCOSMOS = 'dydxcosmos',
   DYN = 'dyn',
   EASY = 'easy',
   EBTCQ = 'ebtcq',

modules/statics/src/networks.ts

@@ -1063,7 +1063,7 @@ class KavaCosmosTestnet extends Testnet implements CosmosNetwork {
 
 class Dydx extends Mainnet implements CosmosNetwork {
   name = 'Dydx';
-  family = CoinFamily.DYDX;
+  family = CoinFamily.DYDXCOSMOS;
   explorerUrl = 'https://www.mintscan.io/dydx/tx/';
   addressPrefix = 'dydx';
   validatorPrefix = 'dydxvaloper';
@@ -1075,7 +1075,7 @@ class Dydx extends Mainnet implements CosmosNetwork {
 
 class DydxTestnet extends Testnet implements CosmosNetwork {
   name = 'DydxTestnet';
-  family = CoinFamily.DYDX;
+  family = CoinFamily.DYDXCOSMOS;
   explorerUrl = 'https://www.mintscan.io/dydx-testnet/tx/';
   addressPrefix = 'dydx';
   validatorPrefix = 'dydxvaloper';

modules/statics/test/unit/coins.ts

@@ -873,7 +873,7 @@ coins.forEach((coin, coinName) => {
     });
 
     if (!coin.isToken && coin.family !== CoinFamily.FIAT) {
-      if (coin.family !== CoinFamily.THOR && coin.family !== CoinFamily.DYDX) {
+      if (coin.family !== CoinFamily.THOR) {
         it(`has expected network type`, function () {
           coin.network.type.should.eql(coin.name === coin.family ? NetworkType.MAINNET : NetworkType.TESTNET);
         });