Merge pull request #7846 from BitGo/win-8531

fix: update decimal and explorer url for hbarevm

Author: rohitsaw115

modules/sdk-coin-xdc/test/unit/xdcToken.ts

@@ -2,7 +2,7 @@ import 'should';
 import { TestBitGo, TestBitGoAPI } from '@bitgo/sdk-test';
 import { BitGoAPI } from '@bitgo/sdk-api';
 
-import { register } from '../../src';
+import { register, XdcToken } from '../../src';
 
 describe('XDC Token:', function () {
   let bitgo: TestBitGoAPI;
@@ -27,4 +27,94 @@ describe('XDC Token:', function () {
     xdcTokenCoin.network.should.equal('Mainnet');
     xdcTokenCoin.decimalPlaces.should.equal(6);
   });
+
+  describe('Token Registration and TransactionBuilder', function () {
+    const mainnetTokens = ['xdc:usdc', 'xdc:lbt', 'xdc:gama', 'xdc:srx', 'xdc:weth'];
+    const testnetTokens = ['txdc:tmt'];
+
+    describe('Mainnet tokens', function () {
+      mainnetTokens.forEach((tokenName) => {
+        it(`${tokenName} should be registered as XdcToken`, function () {
+          const token = bitgo.coin(tokenName);
+          token.should.be.instanceOf(XdcToken);
+        });
+
+        it(`${tokenName} should create TransactionBuilder without error`, function () {
+          const token = bitgo.coin(tokenName) as XdcToken;
+          // @ts-expect-error - accessing protected method for testing
+          (() => token.getTransactionBuilder()).should.not.throw();
+        });
+
+        it(`${tokenName} should use XDC-specific TransactionBuilder`, function () {
+          const token = bitgo.coin(tokenName) as XdcToken;
+          // @ts-expect-error - accessing protected method for testing
+          const builder = token.getTransactionBuilder();
+          builder.should.have.property('_common');
+          // Verify it's using XDC's getCommon, not EVM's
+          // XDC's TransactionBuilder should create successfully without SHARED_EVM_SDK feature
+          builder.constructor.name.should.equal('TransactionBuilder');
+        });
+      });
+    });
+
+    describe('Testnet tokens', function () {
+      testnetTokens.forEach((tokenName) => {
+        it(`${tokenName} should be registered as XdcToken`, function () {
+          const token = bitgo.coin(tokenName);
+          token.should.be.instanceOf(XdcToken);
+        });
+
+        it(`${tokenName} should create TransactionBuilder without error`, function () {
+          const token = bitgo.coin(tokenName) as XdcToken;
+          // @ts-expect-error - accessing protected method for testing
+          (() => token.getTransactionBuilder()).should.not.throw();
+        });
+
+        it(`${tokenName} should use XDC-specific TransactionBuilder`, function () {
+          const token = bitgo.coin(tokenName) as XdcToken;
+          // @ts-expect-error - accessing protected method for testing
+          const builder = token.getTransactionBuilder();
+          builder.should.have.property('_common');
+          builder.constructor.name.should.equal('TransactionBuilder');
+        });
+
+        it(`${tokenName} should have correct base chain`, function () {
+          // eslint-disable-next-line @typescript-eslint/no-explicit-any
+          const token: any = bitgo.coin(tokenName);
+          token.getBaseChain().should.equal('txdc');
+        });
+
+        it(`${tokenName} should not throw "Cannot use common sdk module" error`, function () {
+          const token = bitgo.coin(tokenName) as XdcToken;
+          let errorThrown = false;
+          let errorMessage = '';
+
+          try {
+            // @ts-expect-error - accessing protected method for testing
+            const builder = token.getTransactionBuilder();
+            // Try to use the builder to ensure it's fully functional
+            // @ts-expect-error - type expects TransactionType enum
+            builder.type('Send');
+          } catch (e) {
+            errorThrown = true;
+            errorMessage = (e as Error).message;
+          }
+
+          errorThrown.should.equal(false);
+          errorMessage.should.not.match(/Cannot use common sdk module/);
+        });
+      });
+    });
+
+    it('should verify all XDC tokens use XdcToken class, not EthLikeErc20Token', function () {
+      const allTokens = [...mainnetTokens, ...testnetTokens];
+
+      allTokens.forEach((tokenName) => {
+        const token = bitgo.coin(tokenName);
+        token.should.be.instanceOf(XdcToken);
+        token.constructor.name.should.equal('XdcToken');
+        token.constructor.name.should.not.equal('EthLikeErc20Token');
+      });
+    });
+  });
 });

modules/statics/src/account.ts

@@ -2888,7 +2888,7 @@ export function xdcErc20(
   decimalPlaces: number,
   contractAddress: string,
   asset: UnderlyingAsset,
-  features: CoinFeature[] = [...AccountCoin.DEFAULT_FEATURES, CoinFeature.EIP1559],
+  features: CoinFeature[] = AccountCoin.DEFAULT_FEATURES,
   prefix = '',
   suffix: string = name.toUpperCase(),
   network: AccountNetwork = Networks.main.xdc,

modules/statics/src/allCoinsAndTokens.ts

@@ -2189,7 +2189,7 @@ export const allCoinsAndTokens = [
     'hbarevm',
     'Hedera EVM',
     Networks.main.hederaEVM,
-    8,
+    18,
     UnderlyingAsset.HBAREVM,
     BaseUnit.HBAR,
     [
@@ -2210,7 +2210,7 @@ export const allCoinsAndTokens = [
     'thbarevm',
     'Testnet Hedera EVM',
     Networks.test.hederaEVM,
-    8,
+    18,
     UnderlyingAsset.HBAREVM,
     BaseUnit.HBAR,
     [
@@ -2988,7 +2988,8 @@ export const allCoinsAndTokens = [
     'USD Coin',
     6,
     '0xfa2958cb79b0491cc627c1557f441ef849ca8eb1',
-    UnderlyingAsset['xdc:usdc']
+    UnderlyingAsset['xdc:usdc'],
+    [...AccountCoin.DEFAULT_FEATURES, CoinFeature.STABLECOIN]
   ),
   xdcErc20(
     '8914a1bd-1495-46df-84da-445c6d49edb2',

modules/statics/src/networks.ts

@@ -2166,17 +2166,17 @@ class Plume extends Mainnet implements EthereumNetwork {
 class HederaEVMTestnet extends Testnet implements EthereumNetwork {
   name = 'Testnet Hedera EVM';
   family = CoinFamily.HBAREVM;
-  explorerUrl = 'https://hashscan.io/mainnet/transaction/';
-  accountExplorerUrl = 'https://hashscan.io/mainnet/account/';
+  explorerUrl = 'https://hashscan.io/testnet/transaction/';
+  accountExplorerUrl = 'https://hashscan.io/testnet/account/';
   chainId = 296;
   nativeCoinOperationHashPrefix = '296';
 }
 
 class HederaEVM extends Mainnet implements EthereumNetwork {
   name = 'Hedera EVM';
   family = CoinFamily.HBAREVM;
-  explorerUrl = 'https://hashscan.io/testnet/transaction/';
-  accountExplorerUrl = 'https://hashscan.io/testnet/account/';
+  explorerUrl = 'https://hashscan.io/mainnet/transaction/';
+  accountExplorerUrl = 'https://hashscan.io/mainnet/account/';
   chainId = 295;
   nativeCoinOperationHashPrefix = '295';
 }