Skip to content

Commit 19f496e

Browse files
committed
Remove dependency review workflow
1 parent 458ee34 commit 19f496e

5 files changed

Lines changed: 7 additions & 62 deletions

File tree

.github/dependency-review-config.yml

Lines changed: 0 additions & 23 deletions
This file was deleted.

.github/workflows/dependency-review.yml

Lines changed: 0 additions & 21 deletions
This file was deleted.

CONTRIBUTING.md

Lines changed: 0 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -95,10 +95,6 @@ npm run report:licenses
9595

9696
That command writes generated reports into `reports/licenses/`.
9797

98-
Dependency review also runs automatically on pull requests to catch newly introduced vulnerable dependency changes.
99-
100-
That dependency review config also includes an allowlist for the licenses already present in the current dependency tree. If you intentionally add a dependency under a new acceptable license, update `.github/dependency-review-config.yml` in the same pull request.
101-
10298
## Changing the API Contract
10399

104100
If you modify request or response shapes:

README.md

Lines changed: 0 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -123,12 +123,8 @@ The root check runs:
123123

124124
CodeQL code scanning also runs on GitHub for `javascript-typescript`, `python`, and workflow files.
125125

126-
Pull requests also run GitHub dependency review so new vulnerable dependency changes are easier to catch before merge.
127-
128126
A separate GitHub workflow generates license-report artifacts for the root workspace, frontend workspace, and backend Python environment.
129127

130-
The dependency-review config also keeps a conservative allowlist of licenses already present in the current dependency tree, so tightening policy does not start by breaking routine updates.
131-
132128
An SBOM workflow also publishes SPDX artifacts for the repository source plus the frontend and backend runner images.
133129

134130
## Releases

template-playbook.md

Lines changed: 7 additions & 10 deletions
Original file line numberDiff line numberDiff line change
@@ -64,7 +64,7 @@ Build the second layer early, not after the repo gets messy.
6464

6565
- workflow lint
6666
- secret scan
67-
- dependency review on pull requests
67+
- optional dependency review on pull requests if it stays low-noise for the repo
6868
- license reporting when dependency visibility matters
6969
- SBOM generation for source or publishable artifacts when relevant
7070
- app verification
@@ -279,8 +279,6 @@ Keep:
279279
- `scripts/report-licenses.mjs`
280280
- `.github/workflows/template-ci.yml`
281281
- `.github/workflows/codeql.yml`
282-
- `.github/workflows/dependency-review.yml`
283-
- `.github/dependency-review-config.yml`
284282
- `.github/workflows/license-report.yml`
285283
- `.github/workflows/sbom.yml`
286284
- `SECURITY.md`
@@ -289,7 +287,7 @@ What it should cover:
289287

290288
- tracked git content scanned with `gitleaks` or equivalent
291289
- CodeQL or equivalent static analysis
292-
- dependency review on pull requests
290+
- optional dependency review on pull requests if it behaves cleanly for the dependency ecosystems in the repo
293291
- generated license inventories for package ecosystems in the repo
294292
- SBOM artifacts for source and release artifacts
295293
- private disclosure guidance
@@ -304,7 +302,7 @@ Generic takeaway:
304302

305303
- secret scanning is a near-default for public repos
306304
- CodeQL or equivalent static analysis is a strong baseline for maintained starters
307-
- dependency review gives fast signal before risky packages land
305+
- dependency review can be useful, but it should be kept non-blocking or removed if it creates more noise than signal
308306
- non-blocking license reporting is a good bridge before stricter allowlist enforcement
309307
- SBOM generation is a strong supply-chain visibility layer for deployable templates
310308

@@ -398,9 +396,7 @@ soon.md
398396
.github/ISSUE_TEMPLATE/*
399397
.github/release-drafter.yml
400398
.github/labels.json
401-
.github/dependency-review-config.yml
402399
.github/workflows/template-ci.yml
403-
.github/workflows/dependency-review.yml
404400
.github/workflows/release-drafter.yml
405401
.github/workflows/release.yml
406402
.github/workflows/release-smoke.yml
@@ -421,6 +417,8 @@ Add these if relevant:
421417
scripts/check-contract-drift.mjs
422418
scripts/check-docker-builds.mjs
423419
scripts/check-release-smoke.mjs
420+
.github/dependency-review-config.yml
421+
.github/workflows/dependency-review.yml
424422
docs/assets/*
425423
docs/openapi.yaml
426424
tests/fixtures/*
@@ -453,7 +451,7 @@ For most future non-domain-specific starters, preserve this rough shape:
453451
- secret scan
454452
- app, test, and build verification
455453
- platform-specific verification if relevant
456-
- dependency review
454+
- optional dependency review if it is trustworthy for the repo
457455
- Docker or packaging check if deployable
458456

459457
### Release Layer
@@ -511,7 +509,6 @@ If you want the version that scales better for open source or long-term reuse, a
511509
- `AGENTS.md`
512510
- workflow lint
513511
- CodeQL
514-
- dependency review
515512
- label sync
516513
- release drafter
517514
- release smoke tests
@@ -560,7 +557,7 @@ These patterns are still generic even though the local implementation is CV-shap
560557
- published artifacts should get smoke-tested
561558
- workflows should be linted
562559
- secrets should be scanned
563-
- dependency changes should be reviewed on pull requests
560+
- dependency changes should be reviewed on pull requests when the signal is reliable enough to justify the maintenance cost
564561
- dependency licenses should be reportable without manual digging
565562
- SBOMs should be generated for source trees or release artifacts when supply-chain visibility matters
566563
- published artifacts should have provenance attestations when the platform supports them

0 commit comments

Comments
 (0)