diff --git a/LogicBuilder.Workflow.ComponentModel.Serialization/ComponentModel/Compiler/ValidationError.cs b/LogicBuilder.Workflow.ComponentModel.Serialization/ComponentModel/Compiler/ValidationError.cs index 4971c14..d4ba697 100644 --- a/LogicBuilder.Workflow.ComponentModel.Serialization/ComponentModel/Compiler/ValidationError.cs +++ b/LogicBuilder.Workflow.ComponentModel.Serialization/ComponentModel/Compiler/ValidationError.cs @@ -4,7 +4,6 @@ namespace LogicBuilder.Workflow.ComponentModel.Compiler { - [Serializable()] public sealed class ValidationError(string errorText, int errorNumber, bool isWarning, string propertyName) { private readonly string errorText = errorText; diff --git a/LogicBuilder.Workflow.ComponentModel.Serialization/ComponentModel/Compiler/ValidationErrorCollection.cs b/LogicBuilder.Workflow.ComponentModel.Serialization/ComponentModel/Compiler/ValidationErrorCollection.cs index b5b52e7..2d533b1 100644 --- a/LogicBuilder.Workflow.ComponentModel.Serialization/ComponentModel/Compiler/ValidationErrorCollection.cs +++ b/LogicBuilder.Workflow.ComponentModel.Serialization/ComponentModel/Compiler/ValidationErrorCollection.cs @@ -5,7 +5,6 @@ namespace LogicBuilder.Workflow.ComponentModel.Compiler { - [Serializable()] public sealed class ValidationErrorCollection : Collection { public ValidationErrorCollection() diff --git a/LogicBuilder.Workflow.ComponentModel.Serialization/LogicBuilder.Workflow.ComponentModel.Serialization.csproj b/LogicBuilder.Workflow.ComponentModel.Serialization/LogicBuilder.Workflow.ComponentModel.Serialization.csproj index 580f458..305ee44 100644 --- a/LogicBuilder.Workflow.ComponentModel.Serialization/LogicBuilder.Workflow.ComponentModel.Serialization.csproj +++ b/LogicBuilder.Workflow.ComponentModel.Serialization/LogicBuilder.Workflow.ComponentModel.Serialization.csproj @@ -14,7 +14,7 @@ true Manages serialization of rule sets for .NetStandard. false - Refactoring to accelerate DevOps. + Fixes to improve maintainability and reliability. rules serialization Copyright © Microsoft 2017 https://github.com/BpsLogicBuilder/LogicBuilder.Workflow.ComponentModel.Serialization @@ -44,12 +44,12 @@ - + all runtime; build; native; contentfiles; analyzers; buildtransitive - + diff --git a/Workflow.ComponentModel.Serialization.Tests/ComponentModel/Compiler/ValidationErrorCollectionTest.cs b/Workflow.ComponentModel.Serialization.Tests/ComponentModel/Compiler/ValidationErrorCollectionTest.cs index feac83a..c8199e8 100644 --- a/Workflow.ComponentModel.Serialization.Tests/ComponentModel/Compiler/ValidationErrorCollectionTest.cs +++ b/Workflow.ComponentModel.Serialization.Tests/ComponentModel/Compiler/ValidationErrorCollectionTest.cs @@ -519,5 +519,22 @@ public void AddRange_WithValidationErrorCollection_AddsAllItems() } #endregion + + #region Serialization Tests + + [Fact] + public void ValidationErrorCollection_DoesNotHaveSerializableAttribute() + { + // Arrange + var type = typeof(ValidationErrorCollection); + + // Act + var attributes = type.GetCustomAttributes(typeof(SerializableAttribute), false); + + // Assert + Assert.Empty(attributes); + } + + #endregion } } \ No newline at end of file diff --git a/Workflow.ComponentModel.Serialization.Tests/ComponentModel/Compiler/ValidationErrorTest.cs b/Workflow.ComponentModel.Serialization.Tests/ComponentModel/Compiler/ValidationErrorTest.cs index 84633d0..03df5ba 100644 --- a/Workflow.ComponentModel.Serialization.Tests/ComponentModel/Compiler/ValidationErrorTest.cs +++ b/Workflow.ComponentModel.Serialization.Tests/ComponentModel/Compiler/ValidationErrorTest.cs @@ -573,7 +573,7 @@ public void ToString_ReturnsExpectedFormat(int errorNumber, bool isWarning, stri #region Serialization Tests [Fact] - public void ValidationError_HasSerializableAttribute() + public void ValidationError_DoesNotHaveSerializableAttribute() { // Arrange var type = typeof(ValidationError); @@ -582,7 +582,7 @@ public void ValidationError_HasSerializableAttribute() var attributes = type.GetCustomAttributes(typeof(SerializableAttribute), false); // Assert - Assert.NotEmpty(attributes); + Assert.Empty(attributes); } #endregion diff --git a/Workflow.ComponentModel.Serialization.Tests/Workflow.ComponentModel.Serialization.Tests.csproj b/Workflow.ComponentModel.Serialization.Tests/Workflow.ComponentModel.Serialization.Tests.csproj index 2ed3025..99f9ce2 100644 --- a/Workflow.ComponentModel.Serialization.Tests/Workflow.ComponentModel.Serialization.Tests.csproj +++ b/Workflow.ComponentModel.Serialization.Tests/Workflow.ComponentModel.Serialization.Tests.csproj @@ -13,11 +13,11 @@ - + all runtime; build; native; contentfiles; analyzers; buildtransitive - +