Skip to content

Commit 645b42b

Browse files
committed
Fix: remove remaining usages of naive timestamps
1 parent bbf2700 commit 645b42b

3 files changed

Lines changed: 13 additions & 9 deletions

File tree

tests/test_api/test_01_datapoints.py

Lines changed: 3 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -6,6 +6,8 @@
66
import common
77
from common import ACCEPTED_ERROR_CODES
88

9+
from dp3.common.types import UTC
10+
911

1012
class PushDatapoints(common.APITest):
1113
def test_invalid_payload(self):
@@ -68,7 +70,7 @@ def make_datapoint(data_type: str, value: Any) -> dict[str, Any]:
6870

6971
def make_observation_datapoint(self, data_type: str, value: Any) -> dict[str, Any]:
7072
dp = self.make_datapoint(data_type, value)
71-
dp["t1"] = datetime.utcnow().isoformat()
73+
dp["t1"] = datetime.now(UTC).isoformat()
7274
return dp
7375

7476
def helper_test_datatype_value(self, datapoint: dict, expected_codes: set[int]):

tests/test_example/dps_gen.py

Lines changed: 5 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -1,20 +1,20 @@
11
# Very simple datapoint generator for bus example config
22

3-
import datetime
43
import json
54
import random
5+
from datetime import datetime, timedelta, timezone
66

77

88
class TimeContainer:
99
def __init__(self):
10-
self.time = datetime.datetime.utcnow() - datetime.timedelta(days=4)
10+
self.time = datetime.now(timezone.utc) - timedelta(days=4)
1111

1212
def add_minutes(self, minutes: int):
13-
self.time += datetime.timedelta(minutes=minutes)
13+
self.time += timedelta(minutes=minutes)
1414
return self.time
1515

1616
def add_minutes_no_modify(self, minutes: int):
17-
return self.time + datetime.timedelta(minutes=minutes)
17+
return self.time + timedelta(minutes=minutes)
1818

1919

2020
time = TimeContainer()
@@ -129,7 +129,7 @@ def random_passenger_counts_3():
129129
"back_out": random_passenger_counts_3(),
130130
},
131131
"t1": random_t1_local.isoformat(),
132-
"t2": (random_t1_local + datetime.timedelta(minutes=30)).isoformat(),
132+
"t2": (random_t1_local + timedelta(minutes=30)).isoformat(),
133133
"src": "Bus counter",
134134
}
135135
)

tests/test_example/dps_gen_realtime.py

Lines changed: 5 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -2,12 +2,14 @@
22

33
import random
44
from argparse import ArgumentParser
5-
from datetime import datetime, timedelta
5+
from datetime import datetime, timedelta, timezone
66
from sys import stderr
77
from time import sleep
88

99
import requests
1010

11+
UTC = timezone.utc
12+
1113

1214
def random_initial_location():
1315
latitude = random.uniform(39.0, 41.0)
@@ -22,11 +24,11 @@ def do_random_location_increment(current_location):
2224

2325

2426
def t1():
25-
return datetime.utcnow()
27+
return datetime.now(UTC)
2628

2729

2830
def random_t2():
29-
return datetime.utcnow() + timedelta(minutes=random.randint(5, 15))
31+
return datetime.now(UTC) + timedelta(minutes=random.randint(5, 15))
3032

3133

3234
def random_passenger_counts_3():

0 commit comments

Comments
 (0)