From 4867db83a1dfdda92bfbad80db8b2d0fbda15d25 Mon Sep 17 00:00:00 2001 From: Jeremie Leska Date: Tue, 10 Mar 2026 16:37:18 +0100 Subject: [PATCH 1/2] main BUGFIX fix system capabilities As per-node-capabilities is a keyless list. Create the node-selector with lyd_new_term. Fixes: 473e0ffa3e02 ("main UPDATE implement capabilities modules (#1715)") Link: https://datatracker.ietf.org/doc/html/rfc9196#section-4.2 Signed-off-by: Jeremie Leska --- src/main.c | 9 ++++++++- 1 file changed, 8 insertions(+), 1 deletion(-) diff --git a/src/main.c b/src/main.c index 5c18e47b..d3b1ee6a 100644 --- a/src/main.c +++ b/src/main.c @@ -604,12 +604,19 @@ np2srv_capabilities_oper_cb(sr_session_ctx_t *session, uint32_t sub_id, } if (lyd_new_list(datastore_capas, NULL, "per-node-capabilities", - 0, &per_node_capas, '/')) { + 0, &per_node_capas, "")) { ERR("Failed to create per-node-capabilities."); rc = -1; goto cleanup; } + if (lyd_new_term(per_node_capas, NULL, "node-selector", "/", + 0, NULL)) { + ERR("Failed to create node-selector."); + rc = -1; + goto cleanup; + } + /* per datastore capabilities */ if (np2srv_add_subscription_capabilities(per_node_capas, ly_ctx)) { ERR("Failed to add per node subscription-capabilities."); From d2dd57765dcc82319d352f9e632f7dbc052e1420 Mon Sep 17 00:00:00 2001 From: Jeremie Leska Date: Wed, 11 Mar 2026 11:16:27 +0100 Subject: [PATCH 2/2] test UPDATE fix test_filter Signed-off-by: Jeremie Leska --- tests/test_filter.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/tests/test_filter.c b/tests/test_filter.c index 016e6680..c313175d 100644 --- a/tests/test_filter.c +++ b/tests/test_filter.c @@ -1445,8 +1445,7 @@ test_depth(void **state) GET_DATA_FILTER(st, "ietf-datastores:running", filter, NULL, NULL, 0, 0, 1, 0, NC_WD_ALL); expected = "\n" - " \n" - " \n" + " \n" "\n"; assert_string_equal(st->str, expected); FREE_TEST_VARS(st);