Skip to content

Commit fafcb51

Browse files
authored
[ENG-10546] Technical value “true” is displayed in the search filter tag (#917)
- Ticket: [ENG-10546] - Feature flag: n/a ## Summary of Changes 1. Fixed import. 2. Updated logic for filter chips.
1 parent c048532 commit fafcb51

21 files changed

Lines changed: 146 additions & 233 deletions

src/app/features/admin-institutions/components/filters-section/filters-section.component.spec.ts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -6,7 +6,7 @@ import { ComponentFixture, TestBed } from '@angular/core/testing';
66

77
import { FilterChipsComponent } from '@osf/shared/components/filter-chips/filter-chips.component';
88
import { SearchFiltersComponent } from '@osf/shared/components/search-filters/search-filters.component';
9-
import { DiscoverableFilter, FilterOption } from '@osf/shared/models/search/discaverable-filter.model';
9+
import { DiscoverableFilter, FilterOption } from '@osf/shared/models/search/discoverable-filter.model';
1010
import {
1111
ClearFilterSearchResults,
1212
FetchResources,

src/app/features/admin-institutions/components/filters-section/filters-section.component.ts

Lines changed: 1 addition & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -9,16 +9,14 @@ import { ChangeDetectionStrategy, Component, model } from '@angular/core';
99

1010
import { FilterChipsComponent } from '@osf/shared/components/filter-chips/filter-chips.component';
1111
import { SearchFiltersComponent } from '@osf/shared/components/search-filters/search-filters.component';
12-
import { DiscoverableFilter, FilterOption } from '@osf/shared/models/search/discaverable-filter.model';
12+
import { DiscoverableFilter, FilterOption } from '@osf/shared/models/search/discoverable-filter.model';
1313
import {
1414
ClearFilterSearchResults,
1515
FetchResources,
1616
GlobalSearchSelectors,
1717
LoadFilterOptions,
18-
LoadFilterOptionsAndSetValues,
1918
LoadFilterOptionsWithSearch,
2019
LoadMoreFilterOptions,
21-
SetDefaultFilterValue,
2220
UpdateSelectedFilterOption,
2321
} from '@osf/shared/stores/global-search';
2422

@@ -32,12 +30,10 @@ import {
3230
export class FiltersSectionComponent {
3331
private actions = createDispatchMap({
3432
loadFilterOptions: LoadFilterOptions,
35-
loadFilterOptionsAndSetValues: LoadFilterOptionsAndSetValues,
3633
loadFilterOptionsWithSearch: LoadFilterOptionsWithSearch,
3734
loadMoreFilterOptions: LoadMoreFilterOptions,
3835
updateSelectedFilterOption: UpdateSelectedFilterOption,
3936
clearFilterSearchResults: ClearFilterSearchResults,
40-
setDefaultFilterValue: SetDefaultFilterValue,
4137
fetchResources: FetchResources,
4238
});
4339

src/app/shared/components/filter-chips/filter-chips.component.html

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -2,7 +2,7 @@
22
<div class="flex flex-wrap gap-2">
33
@for (chip of chips(); track chip.key + chip.displayValue) {
44
<p-chip
5-
[label]="chip.label + ': ' + chip.displayValue"
5+
[label]="chip.displayValue === 'true' ? chip.label : chip.label + ': ' + chip.displayValue"
66
removeIcon="fas fa-close"
77
removable
88
(onRemove)="removeFilter(chip.key, chip.option)"

0 commit comments

Comments
 (0)