You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Should there be a separate entry for single token creation in an X range?
If a card has several occurrences, there probably needs to be exclude tags?
When (or after all) to use count="x=1"?
(MIC and MID Tokens #114 (comment), CLB Tokens #147 (review))
How to use placeholder for missing art? (VOW Tokens #125 (comment)), Do not use placeholder elements at all?
Make e.g. sorting and reordering stuff of unrelated elements their own PRs, generally place unrealted changes in seperate PRs as noted in AFR (and most of AFC) Tokens #108
Expand on file documentation in the wiki (https://github.com/Cockatrice/Magic-Token/wiki#documentation) and create and curate a new page.
Also include info about structure, layout and sorting.
The example card comment is also probably better off in the wiki next to its explanation and further details, and only have a link to all doc resource in the token file instead:
https://github.com/Cockatrice/Magic-Token/blob/master/tokens.xml#L15-L32
Place a link in the readme.
Helpful infos and hints for potential guidelines:
relatedbeforereverse-related, sorting (67a2d6c(#108))countbeforeexclude(543b96c(#108))spaces>tabsindentation (fb31047(#108))relatedvs.reverse-related(AFR (and most of AFC) Tokens #108 (comment), Remove all <related> for <reverse-related> #119, --> 67b20ab)
If a card has several occurrences, there probably needs to be exclude tags?
When (or after all) to use
count="x=1"?(MIC and MID Tokens #114 (comment), CLB Tokens #147 (review))
count="x=0"at all? (Trim token file down on not needed extra entries #102 + Remove x=0 values #101)<set>SETCODE</set>vs.<set picURL="">SETCODE</set>?(Kamigawa Tokens #134 --> remove misspellings of picURL #150, CLB Tokens #147 (comment))
&, see CLB Tokens #147 (comment)