diff --git a/debugging/book-library/index.html b/debugging/book-library/index.html index 23acfa71..f14d486b 100644 --- a/debugging/book-library/index.html +++ b/debugging/book-library/index.html @@ -1,12 +1,10 @@ - - + + - - + Book Library + + + @@ -28,19 +26,24 @@

Library

+ // form to add new book
- + // input for book title Library Library type="submit" value="Submit" class="btn btn-primary" - onclick="submit();" + onclick="submit()" />
diff --git a/debugging/book-library/script.js b/debugging/book-library/script.js index 75ce6c1d..6bdf2ef9 100644 --- a/debugging/book-library/script.js +++ b/debugging/book-library/script.js @@ -1,44 +1,54 @@ -let myLibrary = []; +const myLibrary = []; -window.addEventListener("load", function (e) { +window.addEventListener("load", function () { populateStorage(); render(); }); function populateStorage() { if (myLibrary.length == 0) { - let book1 = new Book("Robison Crusoe", "Daniel Defoe", "252", true); - let book2 = new Book( + const book1 = new Book("Robison Crusoe", "Daniel Defoe", 252, true); + const book2 = new Book( "The Old Man and the Sea", "Ernest Hemingway", - "127", + 127, true ); myLibrary.push(book1); myLibrary.push(book2); - render(); } } -const title = document.getElementById("title"); -const author = document.getElementById("author"); -const pages = document.getElementById("pages"); -const check = document.getElementById("check"); +const titleInput = document.getElementById("title"); +const authorInput = document.getElementById("author"); +const pagesInput = document.getElementById("pages"); +const checkInput = document.getElementById("check"); //check the right input from forms and if its ok -> add the new book (object in array) //via Book function and start render function function submit() { - if ( - title.value == null || - title.value == "" || - pages.value == null || - pages.value == "" - ) { - alert("Please fill all fields!"); + const title = titleInput.value.trim(); + const author = authorInput.value.trim(); + const pages = pagesInput.valueAsNumber; + + if (!title) { + alert("Please enter a valid title."); + return false; + } + + if (!author) { + alert("Please enter a valid author."); + return false; + } + + if (!Number.isInteger(pages) || pages <= 0) { + alert("Please enter a valid page number."); return false; } else { - let book = new Book(title.value, title.value, pages.value, check.checked); - library.push(book); + titleInput.value = title; + authorInput.value = author; + let book = new Book(title, author, pages, checkInput.checked); + myLibrary.push(book); render(); } } @@ -51,36 +61,30 @@ function Book(title, author, pages, check) { } function render() { - let table = document.getElementById("display"); - let rowsNumber = table.rows.length; + const table = document.getElementById("display"); + const rowsNumber = table.rows.length; //delete old table - for (let n = rowsNumber - 1; n > 0; n-- { + for (let n = rowsNumber - 1; n > 0; n--) { table.deleteRow(n); } //insert updated row and cells - let length = myLibrary.length; + const length = myLibrary.length; for (let i = 0; i < length; i++) { - let row = table.insertRow(1); - let titleCell = row.insertCell(0); - let authorCell = row.insertCell(1); - let pagesCell = row.insertCell(2); - let wasReadCell = row.insertCell(3); - let deleteCell = row.insertCell(4); - titleCell.innerHTML = myLibrary[i].title; - authorCell.innerHTML = myLibrary[i].author; - pagesCell.innerHTML = myLibrary[i].pages; + const row = table.insertRow(1); + const titleCell = row.insertCell(0); + const authorCell = row.insertCell(1); + const pagesCell = row.insertCell(2); + const wasReadCell = row.insertCell(3); + const deleteCell = row.insertCell(4); + titleCell.textContent = myLibrary[i].title; + authorCell.textContent = myLibrary[i].author; + pagesCell.textContent = myLibrary[i].pages; //add and wait for action for read/unread button - let changeBut = document.createElement("button"); - changeBut.id = i; + const changeBut = document.createElement("button"); changeBut.className = "btn btn-success"; wasReadCell.appendChild(changeBut); - let readStatus = ""; - if (myLibrary[i].check == false) { - readStatus = "Yes"; - } else { - readStatus = "No"; - } + const readStatus = myLibrary[i].check == true ? "Yes" : "No"; changeBut.innerText = readStatus; changeBut.addEventListener("click", function () { @@ -89,14 +93,14 @@ function render() { }); //add delete button to every row and render again - let delButton = document.createElement("button"); - delBut.id = i + 5; - deleteCell.appendChild(delBut); - delBut.className = "btn btn-warning"; - delBut.innerHTML = "Delete"; - delBut.addEventListener("clicks", function () { - alert(`You've deleted title: ${myLibrary[i].title}`); + const deleteBut = document.createElement("button"); + deleteCell.appendChild(deleteBut); + deleteBut.className = "btn btn-warning"; + deleteBut.textContent = "Delete"; + deleteBut.addEventListener("click", function () { + const deletedTitle = myLibrary[i].title; myLibrary.splice(i, 1); + alert(`You've deleted title: ${deletedTitle}`); render(); }); }