COLDBOX-1387 #resolve

Deprecate this.cfmapping on module configuration and use this.mapping instead.

Author: lmajano

.github/copilot-instructions.md

@@ -67,7 +67,7 @@ The ColdBox framework includes several core services in `/system/web/services/`
 - **HandlerService.cfc**: Manages event handling, handler caching, event caching, and handler execution lifecycle
 - **InterceptorService.cfc**: Manages interception points, interceptor registration, and announcement of framework events
 - **LoaderService.cfc**: Responsible for loading and configuring a ColdBox application with all its services during startup
-- **ModuleService.cfc**: Oversees HMVC module management including registration, activation, and CF mapping management
+- **ModuleService.cfc**: Oversees HMVC module management including registration, activation, and Engine mapping management
 - **RequestService.cfc**: Handles request context preparation, FORM/URL processing, and flash scope management
 - **RoutingService.cfc**: Manages URL routing, route registration, and request-to-handler mapping via the Router component
 - **SchedulerService.cfc**: Manages application schedulers in an HMVC fashion for background task execution

.vscode/settings.json

@@ -1,5 +1,5 @@
 {
-    "cfml.mappings": [
+    "boxlang.cfml.mappings": [
 		{
 		  "logicalPath": "/coldbox",
 		  "directoryPath": ".",

system/Bootstrap.cfc

@@ -149,7 +149,7 @@ component serializable="false" accessors="true" {
 						if (
 							structKeyExists( application, appKey ) AND application[ appKey ].getColdboxInitiated() AND needReinit
 						) {
-							// Load Module CF Mappings so modules can unload properly
+							// Load Module Engine Mappings so modules can unload properly
 							application[ appKey ].getModuleService().loadMappings();
 							// process preReinit interceptors
 							application[ appKey ].getInterceptorService().announce( "preReinit" );

system/modules/HTMLHelper/ModuleConfig.cfc

@@ -7,16 +7,16 @@ component {
 	this.title             = "HTML Helper";
 	// Model Namespace
 	this.modelNamespace    = "HTMLHelper";
-	// CF Mapping
-	this.cfmapping         = "HTMLHelper";
+	// Engine Mapping
+	this.mapping         = "HTMLHelper";
 	// Auto-map models
 	this.autoMapModels     = true;
 	// Helpers
 	this.applicationHelper = [ "helpers/Mixins.cfm" ];
 
 	function configure(){
 		// module settings - stored in modules.name.settings
-		settings = {
+		variables.settings = {
 			// The base path of JS assets
 			js_path      : "/includes/js/",
 			// The base path of CSS assets

system/remote/ColdboxProxy.cfc

@@ -49,7 +49,7 @@ component serializable="false" accessors="true" {
 		try {
 			// Locate ColdBox Controller
 			var cbController = getController();
-			// Load Module CF Mappings
+			// Load Module Engine Mappings
 			cbController.getModuleService().loadMappings();
 			// Create the request context
 			var event = cbController.getRequestService().requestCapture( proxyCall: true );

system/testing/VirtualApp.cfc

@@ -73,7 +73,7 @@ component accessors="true" {
 				overrideAppMapping = variables.appMapping,
 				overrideWebMapping = variables.webMapping
 			);
-		// Load Module CF Mappings so modules can work properly
+		// Load Module Engine Mappings so modules can work properly
 		application.cbController.getModuleService().loadMappings();
 		// back to the future!
 		return application.cbController;

system/web/services/ModuleService.cfc

@@ -334,8 +334,8 @@ component extends="coldbox.system.web.services.BaseService" accessors="true" {
 				autoProcessModels : false,
 				// Does the module belong to a bundle or not
 				bundle            : arguments.bundle,
-				// ColdFusion mapping
-				cfmapping         : "",
+				// Engine mapping
+				mapping         : "",
 				// Child modules
 				childModules      : [],
 				// Module Conventions
@@ -480,11 +480,10 @@ component extends="coldbox.system.web.services.BaseService" accessors="true" {
 			mConfig.schedulerInvocationPath &= ".#mConfig.conventions.schedulerLocation#";
 			mConfig.schedulerPhysicalPath &= "/#mConfig.conventions.schedulerLocation.replace( ".", "/", "all" )#";
 
-			// Register CFML Mapping if it exists, for loading purposes
-			// TODO: If a duplicate mapping is detected, warn it to logs
-			if ( len( trim( mConfig.cfMapping ) ) ) {
-				variables.util.addMapping( name = mConfig.cfMapping, path = mConfig.path );
-				variables.mappingRegistry[ "/#mConfig.cfMapping#" ] = mConfig.path;
+			// Register Engine Mapping if it exists, for loading purposes
+			if ( len( trim( mConfig.mapping ) ) ) {
+				variables.util.addMapping( name: mConfig.mapping, path: mConfig.path );
+				variables.mappingRegistry[ "/#mConfig.mapping#" ] = mConfig.path;
 			}
 
 			// Register Custom Interception Points
@@ -564,7 +563,7 @@ component extends="coldbox.system.web.services.BaseService" accessors="true" {
 	 * Load all module mappings
 	 */
 	function loadMappings(){
-		variables.util.addMapping( mappings = variables.mappingRegistry );
+		variables.util.addMapping( mappings : variables.mappingRegistry );
 		return this;
 	}
 
@@ -699,7 +698,7 @@ component extends="coldbox.system.web.services.BaseService" accessors="true" {
 
 				// Add as a mapped directory with module name as the namespace with correct mapping path
 				var packagePath = (
-					len( mConfig.cfmapping ) ? mConfig.cfmapping & ".#mConfig.conventions.modelsLocation#" : mConfig.modelsInvocationPath
+					len( mConfig.mapping ) ? mConfig.mapping & ".#mConfig.conventions.modelsLocation#" : mConfig.modelsInvocationPath
 				);
 
 				// Module Injector : Map with no namespace in the local injector
@@ -1098,7 +1097,7 @@ component extends="coldbox.system.web.services.BaseService" accessors="true" {
 	 * @parent     The parent that invoked the registration
 	 * @parent     The parent injector this module will be linked to
 	 *
-	 * @return struct : { config:cfc, injector:cfc }
+	 * @return struct : { config:class, injector:class }
 	 */
 	struct function loadModuleConfiguration(
 		required struct config,
@@ -1147,9 +1146,10 @@ component extends="coldbox.system.web.services.BaseService" accessors="true" {
 		// version
 		param results.config.version        = "1.0.0";
 		mConfig.version                     = results.config.version;
-		// cf mapping
+		// engine mapping: cfmapping is deprecated but we check for it for backward compatibility
 		param results.config.cfmapping      = "";
-		mConfig.cfmapping                   = results.config.cfmapping;
+		param results.config.mapping        = "";
+		mConfig.mapping                     = len( results.config.mapping ) ? results.config.mapping : results.config.cfmapping;
 		// Module Injector
 		param results.config.moduleInjector = false;
 		mConfig.moduleInjector              = results.config.moduleInjector;

test-harness/modules_app/Inception/ModuleConfig.cfc

@@ -16,8 +16,8 @@ component {
 	this.modelNamespace     = "";
 	// Auto Map Models Directory
 	this.autoMapModels      = true;
-	// CF Mapping
-	this.cfmapping          = "";
+	// Engine Mapping
+	this.mapping          = "";
 
 	function configure(){
 		// parent settings

test-harness/modules_app/Inception/modules/a-inception/ModuleConfig.cfc

@@ -16,8 +16,8 @@ component {
 	this.modelNamespace     = "";
 	// Auto Map Models Directory
 	this.autoMapModels      = true;
-	// CF Mapping
-	this.cfmapping          = "";
+	// Engine Mapping
+	this.mapping          = "";
 	this.dependencies       = [ "Inception" ];
 
 	function configure(){

test-harness/modules_app/Inception/modules/inception-mod1/ModuleConfig.cfc

@@ -16,8 +16,8 @@ component {
 	this.modelNamespace     = "";
 	// Auto Map Models Directory
 	this.autoMapModels      = true;
-	// CF Mapping
-	this.cfmapping          = "";
+	// Engine Mapping
+	this.mapping          = "";
 
 	function configure(){
 		// parent settings