Skip to content

Commit 3e9cf25

Browse files
ZSnakeesezen
andauthored
[REM-2574] Support click tracking for media impressions (#426)
* [REM-2574] Add trackMediaImpressionClick function with tests and types * [REM-2574] Add a valid api key, banner id and placement id for display ads tracking tests * [REM-2574] Update tests to fetch a valid display ads banner. Fix assertions. Extract behavior base URL helper function * Move key to env variable * Spread instead of assign * [REM-2574] Add media api key env variable to bundled test runs --------- Co-authored-by: Enes Kutay SEZEN <eneskutaysezen@gmail.com>
1 parent ba667ce commit 3e9cf25

6 files changed

Lines changed: 341 additions & 35 deletions

File tree

.github/workflows/run-tests-bundled.yml

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -25,4 +25,5 @@ jobs:
2525
run: npm run test:bundled:parallel
2626
env:
2727
TEST_REQUEST_API_KEY: ${{ secrets.TEST_REQUEST_API_KEY }}
28+
TEST_MEDIA_REQUEST_API_KEY: ${{ secrets.TEST_MEDIA_REQUEST_API_KEY }}
2829
SKIP_NETWORK_TIMEOUT_TESTS: true

.github/workflows/run-tests.yml

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -25,4 +25,5 @@ jobs:
2525
run: npm run test:parallel
2626
env:
2727
TEST_REQUEST_API_KEY: ${{ secrets.TEST_REQUEST_API_KEY }}
28+
TEST_MEDIA_REQUEST_API_KEY: ${{ secrets.TEST_MEDIA_REQUEST_API_KEY }}
2829
SKIP_NETWORK_TIMEOUT_TESTS: true

0 commit comments

Comments
 (0)