Adding custom blocks without CreativeInventoryInfo corrupts chunk data(?)

[unickorn]

Tested on a clean server:

class StoneBlock extends Block implements BlockComponents
{
	use BlockComponentsTrait;

	public function __construct(BlockIdentifier $idInfo, string $name, BlockTypeInfo $typeInfo) {
		parent::__construct($idInfo, $name, $typeInfo);

		$this->addComponent(new MaterialInstancesComponent([
			new Material(
				Material::TARGET_ALL, 
				"stone",
				Material::RENDER_METHOD_OPAQUE
			),
		]));
	}
}

CustomiesBlockFactory::getInstance()->registerBlock(static function () {
			return new StoneBlock(new BID(BlockTypeIds::newId()),
				"Stone Block", new BlockTypeInfo(new BlockBreakInfo(3.0)));
		}, "custom:block");

Breaks something with the type IDs, that result in about any block placed showing up as a bunch of random other blocks around the place target to the client.

Registering with CreativeInventoryInfo passed as the last argument to registerBlock works as expected.

[Yexeed]

Yes, cuz maybe this return prevents blocks from being registered?

Customies/src/block/CustomiesBlockFactory.php

Lines 183 to 188 in b1aa5e6

	if($creativeInfo !== null){
	$this->loadGroups();
	if($creativeInfo->getCategory() === CreativeInventoryInfo::CATEGORY_ALL || $creativeInfo->getCategory() === CreativeInventoryInfo::CATEGORY_COMMANDS){
	return;
	}

If a flow enters this branch, the flow goes directly to "return." @jeantkg , did the AI ​​mess something up here? My guess: "missing creative inventory information means a return" should have simply NOT registered information for Creative Inventory, but still not interfere with the registration of the pallete entry?

[HydroGames-dev]

Customies/src/block/CustomiesBlockFactory.php

Line 102 in b1aa5e6

public function registerBlock(Closure $blockFunc, string $identifier, ?CreativeInventoryInfo $creativeInfo = null, ?Closure $serializer = null, ?Closure $deserializer = null): void {

by default ?CreativeInventoryInfo $creativeInfo = null is set to null if you don't mention it in your registration

Customies/src/block/CustomiesBlockFactory.php

Line 172 in b1aa5e6

$creativeInfo ??= CreativeInventoryInfo::DEFAULT();

This line makes it so it always create a CreativeInventoryInfo if it was set to null by default

Customies/src/item/CreativeInventoryInfo.php

Lines 93 to 95 in b1aa5e6

	public static function DEFAULT(): self {
	return new self(self::CATEGORY_ALL, self::NONE);
	}

so by default it sets to Category_All

and this line stops it cuz by default it's category all

Customies/src/block/CustomiesBlockFactory.php

Lines 185 to 187 in b1aa5e6

	if($creativeInfo->getCategory() === CreativeInventoryInfo::CATEGORY_ALL || $creativeInfo->getCategory() === CreativeInventoryInfo::CATEGORY_COMMANDS){
	return;
	}