Currently, the TPReplay application is set to filter out PDS TPs (as at the point of designing the application the flow/implementation of PDS TPs was unknown).
The way the filtering is applied:
To make the TPReplay app also work with PDS TPs:
- either add the PDS-related subdetector to the set
- think about the potential removal of the whole filtering logic at that point
One other important thing to mention:
Because replay expects TPC TPs only, it only creates the infrastructure to deal with those, as shown in the channel map here: https://github.com/DUNE-DAQ/trigger/blob/develop/plugins/TPReplayModule.cpp#L85. Therefore, one also needs to extend the infrastructure to the PDS TPs.
Currently, the TPReplay application is set to filter out PDS TPs (as at the point of designing the application the flow/implementation of PDS TPs was unknown).
The way the filtering is applied:
detidis compared against this set, and filtered out if the detid is NOT in this set of valid subdetectors: https://github.com/DUNE-DAQ/trigger/blob/develop/plugins/TPReplayModule.cpp#L336-L341To make the TPReplay app also work with PDS TPs:
One other important thing to mention:
Because replay expects TPC TPs only, it only creates the infrastructure to deal with those, as shown in the channel map here: https://github.com/DUNE-DAQ/trigger/blob/develop/plugins/TPReplayModule.cpp#L85. Therefore, one also needs to extend the infrastructure to the PDS TPs.