Skip to content

Some _Faxa_ fields are added but not used in CESM #644

@anton-seaice

Description

@anton-seaice

In this section of the FldsExchange:

if (phase == 'advertise') then
call addfld_from(compatm , 'Faxa_sen')
call addfld_aoflux('Faox_sen')
call addfld_from(compice , 'Fioi_melth')
call addfld_to(compocn , 'Foxx_sen')
else
if ( fldchk(is_local%wrap%FBexp(compocn), 'Foxx_sen', rc=rc) .and. &
fldchk(is_local%wrap%FBMed_aoflux_o, 'Faox_sen', rc=rc)) then
call addmrg_to(compocn, 'Foxx_sen', &
mrg_from=compmed, mrg_fld='Faox_sen', mrg_type='merge', mrg_fracname='ofrac')
end if
end if
! ---------------------------------------------------------------------
! to ocn: surface latent heat flux and evaporation water flux
! ---------------------------------------------------------------------
if (phase == 'advertise') then
call addfld_from(compatm, 'Faxa_lat' )
call addfld_aoflux( 'Faox_lat' )
call addfld_aoflux( 'Faox_evap')
call addfld_to(compocn, 'Foxx_lat' )
call addfld_to(compocn, 'Foxx_evap')
else
if ( fldchk(is_local%wrap%FBexp(compocn), 'Foxx_lat', rc=rc)) then
call addmrg_to(compocn, 'Foxx_lat', &
mrg_from=compmed, mrg_fld='Faox_lat', mrg_type='merge', mrg_fracname='ofrac')
end if
if ( fldchk(is_local%wrap%FBExp(compocn), 'Foxx_evap', rc=rc)) then
call addmrg_to(compocn, 'Foxx_evap', &
mrg_from=compmed, mrg_fld='Faox_evap', mrg_type='merge', mrg_fracname='ofrac')
end if
end if

Faxa_sens and Faxa_lat are added from compatm but then nothing is done with them

Both those fluxes are calculated in the aoflux routine instead, and the aoflux calculated fluxes are used.

Is this an error? I think

   call addfld_from(compatm , 'Faxa_sen')
   call addfld_from(compatm, 'Faxa_lat' )

Can be removed (which means they can also be removed from data forcings)

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions