Skip to content

make install should only ever copy files #8971

@daywalker90

Description

@daywalker90

Several times now i encountered an issue with make install doing other things than just copying files. For example: sometimes it would try to compile rust binaries even if you just ran uv run make or now it would try this in the nightly plugins repo CI:

mkdir -p /usr/local/share/man/man7
mkdir -p /usr/local/share/man/man8
mkdir -p /usr/local/share/doc/c-lightning
wiregen wire/peer_wiregen.h
Traceback (most recent call last):
  File "/home/runner/work/plugins/plugins/lightning/tools/generate-wire.py", line 27, in <module>
    from mako.template import Template
ModuleNotFoundError: No module named 'mako'
make: *** [Makefile:359: wire/peer_wiregen.h] Error 1
rm wire/peer_wiregen.h

This all comes from the fact that both rust and uv are often installed per user and make install is often called with sudo which will have a different environment. So if possible make install should not run any python scripts that require dependencies or compile anything ever.

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions