Remove OptionListContextProvider from AuthScreens.tsx and delete the provider

[mountiny]

Problem

After all consumers of useOptionsList have been migrated to useFilteredOptions, the OptionListContextProvider becomes dead code that should be removed.

This is the final cleanup issue in the effort to remove OptionListContextProvider entirely. See parent issue #82193 for full context.

Solution

1. Remove OptionsListContextProvider from the ComposeProviders array in src/libs/Navigation/AppNavigator/AuthScreens.tsx
2. Delete the provider file: src/components/OptionListContextProvider.tsx
3. Update/delete test files that reference the provider:
   • Delete tests/unit/OptionListContextProviderTest.tsx (tests the now-deleted provider)
   • Update tests/perf-test/SearchRouter.perf-test.tsx (remove OptionsListContext.Provider mock)
   • Update tests/ui/PureReportActionItemTest.tsx (remove provider wrapper)
   • Update tests/ui/MoneyRequestReportPreview.test.tsx (remove provider wrapper)
4. Remove any remaining imports/references to OptionListContextProvider, OptionsListContextProvider, OptionsListContext, or useOptionsList across the codebase

Depends on: All other migration sub-issues in this effort must be completed first. Only proceed when there are zero remaining production consumers of useOptionsList.

Complexity: Medium (touches multiple files but straightforward removals)

Reference PR: #74071

Tests

• Verify the app starts and runs correctly without the provider
• Verify all screens that previously used useOptionsList still work (they should now use useFilteredOptions)
• Verify all test suites pass
• Verify no errors appear in the JS console
• Test on all platforms (iOS, Android, Web, Desktop)

Issue Owner

Current Issue Owner: @shubham1206agra

[Julesssss]

Using this to test a MelvinBot run, please ignore the following comment

[MelvinBot]

🔍 Issue Triage

Summary: This is the final cleanup issue in a multi-phase effort to remove OptionListContextProvider. It requires deleting the provider file, removing it from ComposeProviders, and cleaning up test references.

Status: ⛔ Blocked — Not ready to work on

All 11 prerequisite migration sub-issues are still OPEN and none have been started. This issue explicitly depends on zero remaining production consumers of useOptionsList, but there are currently 11 production files still importing it.

Dependency Status

Phase	Issue	Status
1	#82181 — Migrate ShareTab.tsx	🔴 Open
1	#82182 — Migrate UserSelectPopup.tsx	🔴 Open
1	#82183 — Migrate IOURequestEditReportCommon.tsx	🔴 Open
1	#82184 — Migrate TroubleshootPage.tsx	🔴 Open
2	#82185 — Migrate RoomInvitePage.tsx	🔴 Open
2	#82186 — Migrate SearchRouter.tsx	🔴 Open
2	#82187 — Migrate SearchAutocompleteList.tsx	🔴 Open
2	#82188 — Migrate SearchFiltersChatsSelector.tsx	🔴 Open
2	#82189 — Migrate SearchFiltersParticipantsSelector.tsx	🔴 Open
2	#82190 — Migrate MoneyRequestAccountantSelector.tsx	🔴 Open
3	#82191 — Migrate useSearchSelector.base.ts	🔴 Open

Current Production Consumers (11 files)

These files still import useOptionsList from OptionListContextProvider:

1. src/hooks/useSearchSelector.base.ts
2. src/components/Search/SearchFiltersParticipantsSelector.tsx
3. src/components/Search/SearchRouter/SearchRouter.tsx
4. src/components/Search/FilterDropdowns/UserSelectPopup.tsx
5. src/components/Search/SearchFiltersChatsSelector.tsx
6. src/components/Search/SearchAutocompleteList.tsx
7. src/pages/Share/ShareTab.tsx
8. src/pages/RoomInvitePage.tsx
9. src/pages/settings/Troubleshoot/TroubleshootPage.tsx
10. src/pages/iou/request/MoneyRequestAccountantSelector.tsx
11. src/pages/iou/request/step/IOURequestEditReportCommon.tsx

Recommendation

This issue is well-scoped and the solution described is accurate. Once all 11 sub-issues are completed, the cleanup here is straightforward:

• Remove OptionsListContextProvider from ComposeProviders array in AuthScreens.tsx:512
• Delete src/components/OptionListContextProvider.tsx
• Clean up test files (4 files listed in the issue description)

No action should be taken on this issue until all Phase 1-3 sub-issues are closed. Consider adding a Blocked label to signal this clearly.

---

Next Steps: Reply with @MelvinBot implement this once all prerequisite issues are resolved, or @MelvinBot <your feedback> to discuss further.

[MelvinBot]

This request is off-topic for this issue. I can help with:

• Analyzing issues (investigating root causes, tracing code paths)
• Implementing fixes (creating PRs for well-defined issues)
• Answering questions about the codebase
• Fixing failing checks on PRs
• Addressing review comments on PRs

Please reply with a request related to this issue (#82192 — removing OptionListContextProvider), such as @MelvinBot analyze this or @MelvinBot implement this.

[MelvinBot]

🧪 App Flow Test Results

Overall Result: PASS

Tested the Expensify App web build (dev environment). All core flows verified successfully.

Verified Flows

Flow	Status	Details
App loading	✅ Pass	App loaded correctly at dev server with proper styling and branding
Sign-in	✅ Pass	Email auth flow completed successfully (email → Continue → Join)
Onboarding	✅ Pass	Multi-step onboarding completed (work email, purpose, name entry, test drive skip)
Navigation	✅ Pass	All tabs accessible (Home, Inbox, Reports, Workspaces, Account)
Expense creation	✅ Pass	Created a manual $25.00 expense to Manager McTest — appeared in Reports as "Paid"

Console Warnings (non-critical)

• Style validation warnings from React Native Web (textDecoration)
• Development-only React prop warnings (dataElement, dataSourceFile)
• Network errors for dev API endpoints (expected in dev)
• HTML nesting warning: <button> inside <button> in ReferralProgramCTA component
• Onyx warning: set with array type applied to non-array type in bankAccountList

None of these are blocking or related to OptionListContextProvider.

Conclusion

The app is functioning correctly. Sign-in, onboarding, navigation, and expense creation all work end-to-end. Note that this test was run against the current codebase where OptionListContextProvider is still present — this serves as a baseline. Once the provider is removed (after all migration sub-issues are completed), these flows should be re-tested to verify nothing regresses.

[melvin-bot]

@shubham1206agra Uh oh! This issue is overdue by 2 days. Don't forget to update your issues!

[melvin-bot]

@shubham1206agra Still overdue 6 days?! Let's take care of this!