[Due for payment 2026-04-14] Expense - Selection mode persists after undeleting all expenses offline

[mitarachim]

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

---

Version Number: 9.3.51-0
Reproducible in staging?: Yes
Reproducible in production?: N/A - new feature, doesn't exist in prod
If this was caught during regression testing, add the test name, ID and link from BrowserStack: #85818
Email or phone of affected tester (no customers): snodijosdnjoijiosnj@gmail.com
Issue reported by: Applause Internal Team
Bug source: Exploratory - Significant User Experience Deterioration
Device used: iPhone 15 Pro Max / iOS 26.3
App Component: Search

Action Performed:

1. Launch Expensify app.
2. Go to workspace chat.
3. Create an expense.
4. Delete the expense.
5. Go to Reports > Expenses.
6. Click Status, select Deleted and click Apply.
7. Go offline.
8. Long tap on the expense > Select.
9. Tap dropdown button > Undelete.

Expected Result:

Selection mode will exit because there is no more expense.

Actual Result:

Selection mode persists after undeleting all expenses offline.

Workaround:

Unknown

Platforms:

• Android: App
• Android: mWeb Chrome
• iOS: App
• iOS: mWeb Safari
• iOS: mWeb Chrome
• Windows: Chrome
• MacOS: Chrome / Safari

Screenshots/Videos

Bug7118370_1774987727003.ScreenRecording_04-01-2026_04-07-47_1.mp4

View all open jobs on GitHub

Issue Owner

Current Issue Owner: @jakubstec

[melvin-bot]

You have been assigned to this deploy blocker because you recently merged this PR: #85818

[melvin-bot]

💬 A slack conversation has been started in #expensify-open-source

[github-actions]

👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

1. Identify the pull request that introduced this issue and revert it.
2. Find someone who can quickly fix the issue.
3. Fix the issue yourself.

[OSBotify]

🔍 Investigation Summary

Classification: Frontend bug
Causing PR: #85818 - "Deleted transactions on search" by @jnowakow (High confidence)
Related Issues: None

Recommendation: REVERT

PR #85818 introduced the undelete functionality for deleted transactions in search. However, it has a bug in the offline flow where the selection mode persists after undeleting all expenses, even though the expenses are no longer visible in the list.

Labels: Keeping DeployBlockerCash (App deploy blocked - frontend bug requires App PR fix)

📋 Detailed Analysis

Evidence

• The issue was discovered during regression testing of PR [Payment due @rojiphil] Deleted transactions on search #85818
• The bug is reproducible only when performing the undelete action offline (step 8: "Go offline")
• The exact reproduction steps involve filtering for deleted transactions, selecting them, and then undeleting while offline
• Melvin-bot correctly identified PR [Payment due @rojiphil] Deleted transactions on search #85818 as the causing PR in the issue comments

Verification

PR #85818 modifies the following key files related to this bug:

• src/hooks/useSearchBulkActions.ts - Added undelete action handler (lines 719-733)
• src/hooks/useUndeleteTransactions.ts - New hook that calls changeTransactionsReport
• src/libs/actions/Transaction.ts - Modified changeTransactionsReport to handle deleted transactions
• src/components/Search/index.tsx - Selection mode management logic

Root Cause

When undelete is performed offline, the following sequence occurs:

1. Line 729 in useSearchBulkActions.ts: undeleteTransactions(selectedTransactionsKeys) is called

   • This optimistically changes each transaction's reportID from -1 (TRASH_REPORT_ID) to the self DM report ID

2. Line 730: clearSelectedTransactions() is called immediately after

3. The bug: The transactions are optimistically updated and no longer match the "deleted" filter, so they disappear from the list. However, the selected transactions state is not properly cleared, causing selection mode to persist even though there are 0 visible items.

4. In src/components/Search/index.tsx (lines 344-356), there is a useEffect that should turn off selection mode when selectedKeys.length === 0, but this condition is not met because the selection wasn't fully cleared.

The issue is specific to the offline scenario because:

• When online, the backend response likely triggers a search results refresh that clears the stale selected items
• When offline, the optimistic updates change the transactions but the selection state cleanup doesn't complete properly before the re-render