Skip to content

Commit 7bc9468

Browse files
authored
fix(bbr): correct argument order in bbr_get_raw_target_cwnd calls
Fixes #1032
2 parents 22608e4 + 74301b2 commit 7bc9468

File tree

1 file changed

+3
-3
lines changed
  • freebsd/netinet/tcp_stacks

1 file changed

+3
-3
lines changed

freebsd/netinet/tcp_stacks/bbr.c

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -3466,7 +3466,7 @@ bbr_get_target_cwnd(struct tcp_bbr *bbr, uint64_t bw, uint32_t gain)
34663466

34673467
mss = min((bbr->rc_tp->t_maxseg - bbr->rc_last_options), bbr->r_ctl.rc_pace_max_segs);
34683468
/* Get the base cwnd with gain rounded to a mss */
3469-
cwnd = roundup(bbr_get_raw_target_cwnd(bbr, bw, gain), mss);
3469+
cwnd = roundup(bbr_get_raw_target_cwnd(bbr, gain, bw), mss);
34703470
/*
34713471
* Add in N (2 default since we do not have a
34723472
* fq layer to trap packets in) quanta's per the I-D
@@ -10718,8 +10718,8 @@ bbr_get_a_state_target(struct tcp_bbr *bbr, uint32_t gain)
1071810718
mss = min((bbr->rc_tp->t_maxseg - bbr->rc_last_options),
1071910719
bbr->r_ctl.rc_pace_max_segs);
1072010720
/* Get the base cwnd with gain rounded to a mss */
10721-
tar = roundup(bbr_get_raw_target_cwnd(bbr, bbr_get_bw(bbr),
10722-
gain), mss);
10721+
tar = roundup(bbr_get_raw_target_cwnd(bbr, gain,
10722+
bbr_get_bw(bbr)), mss);
1072310723
/* Make sure it is within our min */
1072410724
if (tar < get_min_cwnd(bbr))
1072510725
return (get_min_cwnd(bbr));

0 commit comments

Comments
 (0)