Sonar findings

Author: R-Sandor

server/src/main/java/dev/findfirst/core/config/FileSizeValidator.java

@@ -13,7 +13,9 @@ public class FileSizeValidator implements ConstraintValidator<FileSize, Multipar
   private int maxFileSize;
 
   @Override
-  public void initialize(FileSize constraintAnnotation) {}
+  public void initialize(FileSize constraintAnnotation) {
+    // no op - need to Override ConstraintValidator
+  }
 
   @Override
   public boolean isValid(MultipartFile file, ConstraintValidatorContext context) {

server/src/main/java/dev/findfirst/core/service/TypesenseService.java

@@ -31,6 +31,8 @@ public class TypesenseService {
 
   private final Client client;
 
+  private final String schemaName = "bookmark";
+
   @PostConstruct
   public String createSchema() {
     var q = initRepo.findByScriptName("init");
@@ -45,7 +47,7 @@ public String createSchema() {
 
   private CollectionSchema createCollectionSchemaSchema() {
     CollectionSchema collectionSchema = new CollectionSchema();
-    collectionSchema.name("bookmark")
+    collectionSchema.name(schemaName)
         .addFieldsItem(new Field().name("title").type(FieldTypes.STRING))
         .addFieldsItem(new Field().name("text").type(FieldTypes.STRING));
     return collectionSchema;
@@ -78,7 +80,7 @@ public void addText(BookmarkJDBC bookmark, Document retDoc) {
     document.put("text", retDoc.text());
 
     try {
-      client.collections("bookmark").documents().create(document);
+      client.collections(schemaName).documents().create(document);
     } catch (Exception e) {
       log.error(e.toString());
     }
@@ -88,9 +90,8 @@ public List<Long> search(String text) {
     SearchParameters searchParameters = new SearchParameters().q(text).queryBy("text");
     try {
       log.debug("searching");
-      // log.debug(client.collections("bookmark").documents().;
       SearchResult searchResult =
-          client.collections("bookmark").documents().search(searchParameters);
+          client.collections(schemaName).documents().search(searchParameters);
       log.debug(searchResult.toString());
 
       return searchResult.getHits().stream()

server/src/main/java/dev/findfirst/security/util/KeyGenerator.java

@@ -35,7 +35,6 @@ public static void generateKeys(String privateKeyPath, String publicKeyPath)
     PrivateKey privateKey = pair.getPrivate();
     PublicKey publicKey = pair.getPublic();
 
-    // Encoder encoder = Base64.getEncoder();
     Base64.Encoder encoder = Base64.getEncoder();
 
     // Save the public key in PEM format
@@ -71,7 +70,7 @@ public static void main(String[] args) {
         generateKeys(privateKeyPath, publicKeyPath);
         logger.info("Keys Generated");
       } catch (NoSuchAlgorithmException | IOException e) {
-        e.printStackTrace();
+        logger.error(e.getMessage());
       }
     } else {
       logger.info("Keys already exist.");

server/src/main/java/dev/findfirst/users/controller/UserController.java

@@ -184,8 +184,7 @@ public ResponseEntity<String> uploadProfilePicture(
     }
 
     try {
-      User user =
-          userService.getUserById(uContext.getUserId()).orElseThrow(NoUserFoundException::new);
+      User user = userService.getUserById(uContext.getUserId()).orElseThrow(NoUserFoundException::new);
       userService.changeUserPhoto(user, file);
 
       return ResponseEntity.ok("File uploaded successfully.");
@@ -200,13 +199,12 @@ public ResponseEntity<String> uploadProfilePicture(
   @GetMapping("/profile-picture")
   public ResponseEntity<Resource> getUserProfilePicture(@RequestParam("userId") int userId) {
     try {
-      User user;
-      try {
-        user = userService.getUserById(userId).orElseThrow(() -> new NoUserFoundException());
-      } catch (NoUserFoundException e) {
+      var opt = userService.getUserById(userId);
+      if (opt.isEmpty()) {
         return ResponseEntity.status(HttpStatus.NOT_FOUND).body(null);
-      }
-      String userPhotoPath = user.getUserPhoto();
+      } 
+
+      String userPhotoPath = opt.get().getUserPhoto();
 
       if (userPhotoPath == null || userPhotoPath.isEmpty()) {
         return ResponseEntity.status(HttpStatus.NOT_FOUND).body(null);

server/src/main/java/dev/findfirst/users/service/UserManagementService.java

@@ -3,6 +3,7 @@
 import java.io.File;
 import java.io.IOException;
 import java.nio.charset.StandardCharsets;
+import java.nio.file.Files;
 import java.nio.file.Path;
 import java.rmi.UnexpectedException;
 import java.time.Instant;
@@ -102,7 +103,7 @@ public void changeUserPhoto(User user, MultipartFile file)
 
     // Save new photo
     String fileName = "userphoto_" + UUID.randomUUID() + ".png";
-    File destinationFile = new File(Path.of(uploadLocation).normalize() + "/" + fileName);
+    File destinationFile = Path.of(uploadLocation, fileName).normalize().toFile();
 
     file.transferTo(destinationFile);
     String userPhoto = uploadLocation + fileName;
@@ -119,7 +120,11 @@ public void removeUserPhoto(User user) {
       File photoFile = new File(userPhoto);
       if (photoFile.exists()) {
         log.info("Removing profile picture for user ID {}: {}", user.getUserId(), userPhoto);
-        photoFile.delete();
+        try {
+          Files.delete(photoFile.toPath());
+        } catch (IOException e) {
+          log.error(e.getMessage());
+        }
         user.setUserPhoto(null);
         saveUser(user);
       }

server/src/test/java/dev/findfirst/core/service/TypesenseServiceTest.java

@@ -9,6 +9,7 @@
 import dev.findfirst.core.model.jdbc.TypesenseInitRecord;
 import dev.findfirst.core.repository.jdbc.TypsenseInitializationRepository;
 
+import org.junit.jupiter.api.Disabled;
 import org.junit.jupiter.api.Test;
 import org.junit.jupiter.api.extension.ExtendWith;
 import org.mockito.InjectMocks;
@@ -75,6 +76,7 @@ void initializationWasNotFinished() throws Exception {
   }
 
   @Test
+  @Disabled("Implement test to save storeScrapedText")
   void storeScrapedText() throws Exception {
 
   }