chore: send every error to stderr

Author: iffse

framework_lib/src/capsule.rs

@@ -185,7 +185,7 @@ pub fn dump_winux_image(data: &[u8], header: &DisplayCapsule, filename: &str) {
     {
         let ret = crate::fw_uefi::fs::shell_write_file(filename, image);
         if let Err(err) = ret {
-            println!("Failed to dump winux image: {:?}", err);
+            eprintln!("Failed to dump winux image: {:?}", err);
         }
     }
 }

framework_lib/src/ccgx/hid.rs

@@ -290,7 +290,7 @@ pub fn flash_firmware(fw_binary: &[u8]) {
     let versions = if let Some(versions) = ccgx::binary::read_versions(fw_binary, SiliconId::Ccg3) {
         versions
     } else {
-        println!("Incompatible firmware. Need CCG3 firmware.");
+        eprintln!("Incompatible firmware. Need CCG3 firmware.");
         return;
     };
 
@@ -302,7 +302,7 @@ pub fn flash_firmware(fw_binary: &[u8]) {
     } else if util::find_sequence(fw_binary, dp_string).is_some() {
         [DP_CARD_PID]
     } else {
-        println!("Incompatible firmware. Need DP/HDMI Expansion Card Firmware.");
+        eprintln!("Incompatible firmware. Need DP/HDMI Expansion Card Firmware.");
         return;
     };
 
@@ -319,7 +319,7 @@ pub fn flash_firmware(fw_binary: &[u8]) {
     let mut api = HidApi::new().unwrap();
     let devices = find_devices(&api, &filter_devs, None);
     if devices.is_empty() {
-        println!("No compatible Expansion Card connected");
+        eprintln!("No compatible Expansion Card connected");
         return;
     };
     for dev_info in devices {

framework_lib/src/ccgx/mod.rs

@@ -302,7 +302,7 @@ fn parse_metadata_cyacd2(buffer: &[u8]) -> Option<(u32, u32)> {
         if metadata.metadata_version == 1 {
             Some((metadata.fw_start, metadata.fw_size))
         } else {
-            println!("Unknown CCG8 metadata version");
+            eprintln!("Unknown CCG8 metadata version");
             None
         }
     } else {

framework_lib/src/chromium_ec/cros_ec.rs

@@ -79,7 +79,7 @@ fn init() {
         return;
     }
     match std::fs::File::open(DEV_PATH) {
-        Err(why) => println!("Failed to open {}. Because: {:?}", DEV_PATH, why),
+        Err(why) => eprintln!("Failed to open {}. Because: {:?}", DEV_PATH, why),
         Ok(file) => *device = Some(file),
     };
     // 2. Read max 80 bytes and check if equal to "1.0.0"

framework_lib/src/chromium_ec/mod.rs

@@ -975,7 +975,7 @@ impl CrosEc {
             if !dry_run {
                 let res = self.write_ec_flash_chunk(addr + offset as u32, chunk);
                 if let Err(err) = res {
-                    println!("  Failed to write chunk: {:?}", err);
+                    eprintln!("  Failed to write chunk: {:?}", err);
                     return Err(err);
                 }
             }
@@ -1062,7 +1062,7 @@ impl CrosEc {
                 // TODO: We don't want to crash here. But returning no data doesn't seem optimal
                 // either
                 // return Err(EcError::DeviceError("Execution interrupted".to_string()));
-                println!("Execution interrupted");
+                eprintln!("Execution interrupted");
                 return Ok(vec![]);
             }
 
@@ -1142,15 +1142,15 @@ impl CrosEc {
         // TODO: Does zephyr always start like this?
         let zephyr_start = [0x5E, 0x4D, 0x3B, 0x2A];
         if data[0..4] != legacy_start && data[0..4] != zephyr_start {
-            println!("      INVALID start");
+            eprintln!("      INVALID start");
             res = Err(EcError::DeviceError("INVALID start".to_string()));
         }
         // Legacy EC is all 0xFF until the end of the row
         // Zephyr EC I'm not quite sure but it has a section of 0x00
         let legacy_comp = !data[4..].iter().all(|x| *x == 0xFF);
         let zephyr_comp = !data[0x20..0x40].iter().all(|x| *x == 0x00);
         if legacy_comp && zephyr_comp {
-            println!("      INVALID end");
+            eprintln!("      INVALID end");
             res = Err(EcError::DeviceError("INVALID end".to_string()));
         }
 
@@ -1175,13 +1175,13 @@ impl CrosEc {
         // let legacy_start = []; // TODO
         // let zephyr_start = [0x80, 0x7D, 0x0C, 0x20];
         // if data[0..4] != legacy_start && data[0..4] != zephyr_start {
-        //     println!("      INVALID start");
+        //     eprintln!("      INVALID start");
         //     res = Err(EcError::DeviceError("INVALID start".to_string()));
         // }
         // let legacy_comp = !data[4..].iter().all(|x| *x == 0xFF);
         // let zephyr_comp = !data[0x20..0x2C].iter().all(|x| *x == 0x00);
         // if legacy_comp && zephyr_comp {
-        //     println!("      INVALID end");
+        //     eprintln!("      INVALID end");
         //     res = Err(EcError::DeviceError("INVALID end".to_string()));
         // }
 
@@ -1224,7 +1224,7 @@ impl CrosEc {
             println!("      Erased flash flags");
             res = Err(EcError::DeviceError("Erased flash flags".to_string()));
         } else {
-            println!("      INVALID flash flags: {:02X?}", &data[0..12]);
+            eprintln!("      INVALID flash flags: {:02X?}", &data[0..12]);
             // TODO: Disable error until I confirm flash flags on MEC
             // res = Err(EcError::DeviceError("INVALID flash flags".to_string()));
         }

framework_lib/src/chromium_ec/windows.rs

@@ -52,10 +52,12 @@ fn init() -> bool {
             match platform {
                 Some(platform @ Platform::IntelGen11)
                 | Some(platform @ Platform::IntelGen12)
-                | Some(platform @ Platform::IntelGen13) => {
-                    println!("The windows driver is not enabled on {:?}.", platform);
-                    println!("Please stay tuned for future BIOS and driver updates.");
-                    println!();
+                | Some(platform @ Platform::IntelGen13)
+                | Some(platform @ Platform::Framework13Amd7080)
+                | Some(platform @ Platform::Framework16Amd7080) => {
+                    eprintln!("The windows driver is not enabled on {:?}.", platform);
+                    eprintln!("Please stay tuned for future BIOS and driver updates.");
+                    eprintln!();
                 }
                 Some(Platform::IntelCoreUltra1) => {
                     println!("The windows driver has been enabled since BIOS 3.06.");