Fix clippy warnings

Signed-off-by: Daniel Schaefer <dhs@frame.work>

Author: JohnAZoidberg

b1display/src/main.rs

@@ -57,7 +57,7 @@ struct Delay(cortex_m::delay::Delay);
 impl DelayNs for Delay {
     fn delay_ns(&mut self, ns: u32) {
         // Round up to microseconds
-        self.0.delay_us((ns + 999) / 1000);
+        self.0.delay_us(ns.div_ceil(1000));
     }
 
     fn delay_us(&mut self, us: u32) {

fl16-inputmodules/src/animations.rs

@@ -119,7 +119,7 @@ impl Iterator for GameOfLifeIterator {
         if self.frames_remaining > 0 {
             self.frames_remaining -= 1;
             // Only update every 8th frame, otherwise the animation is too fast
-            if self.frames_remaining % 8 == 0 {
+            if self.frames_remaining.is_multiple_of(8) {
                 self.state.tick();
             }
             Some(self.state.draw_matrix())

fl16-inputmodules/src/games/game_of_life.rs

@@ -84,7 +84,7 @@ impl GameOfLifeState {
         for row in 0..HEIGHT {
             for col in 0..WIDTH {
                 let i = col * HEIGHT + row;
-                if i % 2 == 0 || i % 7 == 0 {
+                if i.is_multiple_of(2) || i.is_multiple_of(7) {
                     cells[row][col] = Cell::Alive;
                 }
             }

fl16-inputmodules/src/games/snake_animation.rs

@@ -32,7 +32,7 @@ impl Iterator for SnakeIterator {
         }
 
         // Slow down animation by a factor of 4
-        if self.current_tick % 4 == 0 {
+        if self.current_tick.is_multiple_of(4) {
             let (maybe_cmd, random) = self.commands[self.current_tick / 4];
             if let Some(command) = maybe_cmd {
                 self.state.handle_control(&command);

fl16-inputmodules/src/serialnum.rs

@@ -3,7 +3,7 @@ const FLASH_OFFSET: usize = 0x10000000;
 const LAST_4K_BLOCK: usize = 0xff000;
 const SERIALNUM_LEN: usize = 18;
 
-#[repr(packed)]
+#[repr(C, packed)]
 pub struct SerialnumStructRaw {
     sn_rev: u8,
     serialnum: [u8; SERIALNUM_LEN],

inputmodule-control/src/inputmodule.rs

@@ -1080,8 +1080,7 @@ fn gif_cmd(serialdev: &str, image_path: &str) {
         let img = std::fs::File::open(image_path).unwrap();
         let gif = GifDecoder::new(img).unwrap();
         let frames = gif.into_frames();
-        for (_i, frame) in frames.enumerate() {
-            //println!("Frame {i}");
+        for frame in frames {
             let frame = frame.unwrap();
             //let delay = frame.delay();
             //println!("  Delay: {:?}", Duration::from(delay));

inputmodule-control/src/ledmatrix.rs

@@ -14,6 +14,7 @@ pub enum Pattern {
     //AllBrightnesses
 }
 
+#[allow(clippy::enum_variant_names)]
 #[derive(Clone, Copy, Debug, PartialEq, clap::ValueEnum)]
 #[repr(u8)]
 pub enum Game {

ledmatrix/src/main.rs

@@ -627,7 +627,7 @@ fn handle_sleep(
                 let mut brightness = state.brightness;
                 loop {
                     delay.delay_ms(100);
-                    brightness = if brightness <= 5 { 0 } else { brightness - 5 };
+                    brightness = brightness.saturating_sub(5);
                     set_brightness(state, brightness, matrix);
                     if brightness == 0 {
                         break;