@@ -521,12 +521,16 @@ void whenQueryingFutureChannelBansWithTargetUserId_thenFiltersCorrectly() {
521521 usersUpsertRequest .user (UserRequestObject .builder ().id (targetId2 ).name ("Target 2" ).build ());
522522 Assertions .assertDoesNotThrow (() -> usersUpsertRequest .request ());
523523
524+ // Use the test channel's CID for banning from future channels
525+ String channelCid = testChannel .getType () + ":" + testChannel .getId ();
526+
524527 // Ban both targets from future channels created by creator
525528 Assertions .assertDoesNotThrow (
526529 () ->
527530 User .ban ()
528531 .userId (creatorId )
529532 .targetUserId (targetId1 )
533+ .channelCid (channelCid )
530534 .banFromFutureChannels (true )
531535 .reason ("test ban 1" )
532536 .request ());
@@ -536,6 +540,7 @@ void whenQueryingFutureChannelBansWithTargetUserId_thenFiltersCorrectly() {
536540 User .ban ()
537541 .userId (creatorId )
538542 .targetUserId (targetId2 )
543+ .channelCid (channelCid )
539544 .banFromFutureChannels (true )
540545 .reason ("test ban 2" )
541546 .request ());
@@ -546,26 +551,27 @@ void whenQueryingFutureChannelBansWithTargetUserId_thenFiltersCorrectly() {
546551 () ->
547552 User .queryFutureChannelBans ().userId (creatorId ).targetUserId (targetId1 ).request ());
548553 Assertions .assertEquals (1 , response .getBans ().size ());
549- Assertions .assertEquals (targetId1 , response .getBans ().get (0 ).getUser ().getId ());
554+ // For future channel bans, banned_by contains the creator (userId)
555+ Assertions .assertEquals (creatorId , response .getBans ().get (0 ).getBannedBy ().getId ());
550556
551557 // Query for the other target
552558 response =
553559 Assertions .assertDoesNotThrow (
554560 () ->
555561 User .queryFutureChannelBans ().userId (creatorId ).targetUserId (targetId2 ).request ());
556562 Assertions .assertEquals (1 , response .getBans ().size ());
557- Assertions .assertEquals (targetId2 , response .getBans ().get (0 ).getUser ().getId ());
563+ Assertions .assertEquals (creatorId , response .getBans ().get (0 ).getBannedBy ().getId ());
558564
559565 // Query all future channel bans by creator (without target filter)
560566 response =
561567 Assertions .assertDoesNotThrow (
562568 () -> User .queryFutureChannelBans ().userId (creatorId ).request ());
563569 Assertions .assertTrue (response .getBans ().size () >= 2 );
564570
565- // Cleanup - unban both users
571+ // Cleanup - unban both users (createdBy is required when removing future channel bans)
566572 Assertions .assertDoesNotThrow (
567- () -> User .unban (targetId1 ).removeFutureChannelsBan (true ).request ());
573+ () -> User .unban (targetId1 ).removeFutureChannelsBan (true ).createdBy ( creatorId ). request ());
568574 Assertions .assertDoesNotThrow (
569- () -> User .unban (targetId2 ).removeFutureChannelsBan (true ).request ());
575+ () -> User .unban (targetId2 ).removeFutureChannelsBan (true ).createdBy ( creatorId ). request ());
570576 }
571577}
0 commit comments