Merge pull request #14 from GoodRequest/fix/GRResult

fix: GRResult isFailure condition

Author: DominikPetho

Sources/GoodStructs/Either&Result.swift

@@ -191,7 +191,7 @@ public enum GRResult<V, E> {
 
     public var isFailure: Bool {
         switch self {
-        case .success:
+        case .failure:
             return true
 
         default:

Tests/GoodCompatibleTests/BaseTests.swift

@@ -4,7 +4,7 @@ import GRCompatible
 final class BaseTests: XCTestCase {
 
     func testBaseType() {
-        assert("Hello".gr.base != nil)
+        XCTAssert("Hello".gr.base != nil)
     }
 
 }

Tests/GoodRequestManagerTests/GRSessionTests.swift

@@ -45,7 +45,7 @@ final class GRSessionTests: XCTestCase {
 
     func testGRSession() {
         let session = GRSession<Endpoint, Base>(configuration: .default, baseURL: .base)
-        assert(true)
+        XCTAssert(true)
     }
 
 }

Tests/GoodStructsTests/EitherTests.swift

@@ -5,9 +5,9 @@ final class EitherTests: XCTestCase {
 
     func testEither() {
         let value = Either<Int,String>.left(5)
-        assert(try! value.unwrapLeft() == 5)
+        XCTAssert(try! value.unwrapLeft() == 5)
         let value2 = Either<Int,String>.right("Hello")
-        assert(try! value2.unwrap() == "Hello")
+        XCTAssert(try! value2.unwrap() == "Hello")
     }
 
     static var allTests = [

Tests/GoodStructsTests/GRResultTests.swift

@@ -0,0 +1,75 @@
+//
+//  GRResultTests.swift
+//  
+//
+//  Created by Dominik Pethö on 12/8/21.
+//
+import XCTest
+import GoodStructs
+
+final class GRResultTests: XCTestCase {
+
+    enum TestError: Error, Equatable {
+        
+        case invalid
+        case unknown
+        
+    }
+    
+    let grSuccessResult = GRResult<Int, TestError>.success(10)
+    let grFailureResult = GRResult<Int, TestError>.failure(.invalid)
+    let grLoadingResult = GRResult<Int, TestError>.loading
+    
+    func testUnwrapSuccessValueFromSuccessResult() {
+        let value = try? grSuccessResult.unwrapSuccess()
+        XCTAssert(value == 10)
+    }
+    
+    func testUnwrapSuccessValueFromFailureResult() {
+        let value = try? grFailureResult.unwrapSuccess()
+        XCTAssert(value == nil)
+    }
+    
+    func testUnwrapFailureValueFromSuccessResult() {
+        let value = try? grSuccessResult.unwrapFailure()
+        XCTAssert(value == nil)
+    }
+    
+    func testUnwrapFailureValueFromFailureResult() {
+        let value = try? grFailureResult.unwrapFailure()
+        XCTAssert(value == .invalid)
+    }
+    
+    func testIsSuccessConditionsForAllTypeOfResults() {
+        XCTAssert(grSuccessResult.isSuccess && !grFailureResult.isSuccess && !grLoadingResult.isSuccess)
+    }
+    
+    func testIsFailureConditionsForAllTypeOfResults() {
+        XCTAssert(!grSuccessResult.isFailure && grFailureResult.isFailure && !grLoadingResult.isFailure)
+    }
+    
+    func testIsLoadingConditionsForAllTypeOfResults() {
+        XCTAssert(!grSuccessResult.isLoading && !grFailureResult.isLoading && grLoadingResult.isLoading)
+    }
+    
+    func testMapFunctionForSuccessType() {
+        let value = try? grSuccessResult.map { $0 * 2 }.unwrapSuccess()
+        XCTAssert(value == 20)
+    }
+    
+    func testMapFunctionForFailureType() {
+        let value = try? grFailureResult.map { $0 * 2 }.unwrapSuccess()
+        XCTAssert(value == nil)
+    }
+    
+    func testMapErrorFunctionForSuccessType() {
+        let error = try? grSuccessResult.mapError { _ in TestError.unknown }.unwrapFailure()
+        XCTAssert(error == nil)
+    }
+    
+    func testMapErrorFunctionForFailureType() {
+        let error = try? grFailureResult.mapError { _ in TestError.unknown }.unwrapFailure()
+        XCTAssert(error == .unknown)
+    }
+    
+}