Skip to content

GRAL read anomaly of gff #49

@JoshLovesFun

Description

@JoshLovesFun

Describe the bug
When running GRAL (run 1), if the gff file doesn't exist, GRAL creates it, then creates the grz file. The concentrations are as expected.
However, when running GRAL a second time (run 2), if the same gff file from the exact above simulation is read from for the next GRAL simulation, the resulting concentrations are slightly different. However, if GRAL is run again for the same exact simulation (run 3), but this time I delete the gff file from run 1, the concentration results are equal to run 1.

To Reproduce
Steps to reproduce the behavior:

  1. GRAL ran with reproducible results option to verify the slight differences in results (depending on presence of existing gff).
  2. GRAL run with steady state mode and buildings and point sources.
  3. GRAL was ran outside the GUI to isolate the problem.
  4. Resulting concentrations were compared using the GUI. The concentrations files were slightly different between these 2 cases.
    Expected behavior
    It is expected that if the gff file already exists, GRAL would use it. I see this happening as I see the advection scheme is skipped. I would expect identical results between GRAL runs if the gff file is unavailable (run 1 - file is created during run), compared to if the gff file is available (from run 1 - file already has been created).

I have found that the results are consistently different. Meaning multiple GRAL runs from scratch result in max concentration of 931, whereas multiple GRAL runs with the gff already present from the first run yield max concentration of 933.
As you can see. This is a very small difference.

Desktop (please complete the following information):

  • OS: Windows 11

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions