- Added target to menu items

Author: dash8x

README.md

@@ -58,6 +58,10 @@ class AdminSidebar extends Menu implements IsMenu
                     return $request->query('foo') == 'bars';
                 })
                 ->badge(__('New'), 'text-bg-primary'),
+                
+            MenuItem::make(__('External Link'))
+                ->url('https://google.com')
+                ->target('_blank'),                    
         ];
     }
 }
@@ -91,6 +95,7 @@ You may use the following methods to further configure the menu item:
 - `children` - sets the children of the menu item. Note that the default views support only 2 levels of items. If you want more levels or infinite levels, you can supply your own view when rendering the menu.
 - `hideIfNoChildrenVisible` - hides the menu item if it has children but doesn't have any visible children. By default, this option is active for items with blank links.
 - `dontHideIfNoChildrenVisible` - don't hide the menu item even if it has no visible children
+- `target` - sets the `href` target of the menu item
 
 ### Displaying a Menu
 
@@ -164,6 +169,8 @@ $item->getCssClass() // returns the custom css class, if any set for the item
 $item->getAggregatedCount($user) // get the count of the item + the count of all visible child items, will return 0 if the current user can't see the count
 $item->getVisibleCount($user) // get the count of the item, will return 0 if the current user can't see the count
 $item->getVisibleChildren($user) // returns an array of all visible child items
+$item->hasTarget() // checks if the item has a href target value defined
+$item->getTarget() // returns the item's href target attribute value
 ```
 
 If you want to customize the default views, you can publish the package views and customize them. To publish the view files to `resources/views/vendor/menu-builder`, run:

resources/views/bootstrap-5/child-menu-item.blade.php

@@ -1,5 +1,8 @@
 <li class="nav-item{{ $item->hasCssClass() ? ' ' . $item->getCssClass() : '' }}">
     <a href="{{ $item->getLink() }}"
+       @if($item->hasTarget())
+           target="{{ $item->getTarget() }}"
+       @endif
        @class([
             'nav-link d-flex justify-content-between align-items-center',
             'active' => $item->isActive()

resources/views/bootstrap-5/root-menu-item.blade.php

@@ -1,5 +1,8 @@
 <li class="nav-item{{ $item->hasCssClass() ? ' ' . $item->getCssClass() : '' }}">
     <a href="{{ $item->getLink() }}"
+       @if($item->hasTarget())
+           target="{{ $item->getTarget() }}"
+       @endif
        @class([
             'nav-link d-flex justify-content-between align-items-center',
             'active' => $item->isActive() || $item->hasActiveChild($user)

resources/views/material-admin-26/child-menu-item.blade.php

@@ -10,7 +10,11 @@
         ])
     @endif
 >
-    <a href="{{ $item->getLink() }}" class="d-flex justify-content-between align-items-center">
+    <a href="{{ $item->getLink() }}"
+       @if($item->hasTarget())
+           target="{{ $item->getTarget() }}"
+       @endif
+       class="d-flex justify-content-between align-items-center">
         <span>{{ $item->getLabel() }}</span>
         @if($count = $item->getVisibleCount($user))
         <span class="badge badge-pill bg-primary align-self-start">{{ $count }}</span>

resources/views/material-admin-26/root-menu-item.blade.php

@@ -14,7 +14,11 @@
         ])
     @endif
     >
-    <a href="{{ $item->getLink() }}">
+    <a href="{{ $item->getLink() }}"
+        @if($item->hasTarget())
+            target="{{ $item->getTarget() }}"
+        @endif
+    >
         @if($item->hasIcon())<i class="{{ $item->getIcon($icon_prefix) }}"></i> @endif{{ $item->getLabel() }}
         @if($count = $item->getAggregatedCount($user))
             <span class="ml-2 badge badge-pill">{{ $count }}</span>

src/Menu/MenuItem.php

@@ -16,6 +16,7 @@
 use Javaabu\MenuBuilder\Traits\HasPermission;
 use Javaabu\MenuBuilder\Traits\HasRoute;
 use Javaabu\MenuBuilder\Traits\HasRoutePatterns;
+use Javaabu\MenuBuilder\Traits\HasTarget;
 use Javaabu\MenuBuilder\Traits\HasUrl;
 
 class MenuItem
@@ -31,6 +32,7 @@ class MenuItem
     use HasCount;
     use HasBadge;
     use HasCssClass;
+    use HasTarget;
     use CanHaveChildren;
     use Macroable;
 

src/Traits/HasTarget.php

@@ -0,0 +1,27 @@
+<?php
+
+namespace Javaabu\MenuBuilder\Traits;
+
+use Closure;
+
+trait HasTarget
+{
+    protected Closure | string | null $target = null;
+
+    public function target(Closure | string | null $badge): self
+    {
+        $this->target = $badge;
+
+        return $this;
+    }
+
+    public function getTarget(): ?string
+    {
+        return $this->evaluate($this->target);
+    }
+
+    public function hasTarget(): bool
+    {
+        return ! empty($this->getTarget());
+    }
+}

tests/Menus/Sidebar.php

@@ -45,6 +45,7 @@ public function menuItems(): array
 
             MenuItem::make('Returns')
                 ->url('http://localhost/returns')
+                ->target('_blank')
                 ->icon('assignment-return')
                 ->badge(__('Error'), 'text-bg-danger'),
         ];

tests/Unit/MenuItemTest.php

@@ -32,6 +32,14 @@ public function it_can_set_the_menu_item_class(): void
         $this->assertEquals('new', $menu_item->getCssClass());
     }
 
+    /** @test */
+    public function it_can_set_the_menu_item_target(): void
+    {
+        $menu_item = MenuItem::make('Dashboard')->target('_blank');
+
+        $this->assertEquals('_blank', $menu_item->getTarget());
+    }
+
     /** @test */
     public function it_can_set_the_menu_item_badge(): void
     {

tests/stubs/bootstrap-5.blade.php

@@ -35,7 +35,7 @@
         </a>
     </li>
     <li class="nav-item">
-        <a href="http://localhost/returns" class="nav-link d-flex justify-content-between align-items-center">
+        <a href="http://localhost/returns" target="_blank" class="nav-link d-flex justify-content-between align-items-center">
             <span><i class="zmdi zmdi-assignment-return"></i> Returns</span>
             <span class="ms-2 badge text-bg-danger rounded-pill">Error</span>
         </a>