From 38602bdf2fe94ae6d041de782f470a27133b90dd Mon Sep 17 00:00:00 2001
From: John Fawcett <john@kilocode.ai>
Date: Wed, 1 Apr 2026 03:49:57 +0000
Subject: [PATCH] fix(gastown): stop false-positive invariant violations
 spamming logs every 5s
MIME-Version: 1.0
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 8bit

Invariant 7: Exclude mayors from the 'working agent must have a hook'
check — mayors are always working and intentionally hookless.

Invariant 5: Widen valid convoy bead states to include in_progress and
in_review, which are legitimate transient states while child beads are
being worked on. Only flag truly unexpected states.

Fixes #1364
---
 cloudflare-gastown/src/dos/town/reconciler.ts | 17 ++++++++++-------
 1 file changed, 10 insertions(+), 7 deletions(-)

diff --git a/cloudflare-gastown/src/dos/town/reconciler.ts b/cloudflare-gastown/src/dos/town/reconciler.ts
index e9fef8d21..4f8664f96 100644
--- a/cloudflare-gastown/src/dos/town/reconciler.ts
+++ b/cloudflare-gastown/src/dos/town/reconciler.ts
@@ -1494,6 +1494,7 @@ export function checkInvariants(sql: SqlStorage): Violation[] {
   const violations: Violation[] = [];
 
   // Invariant 7: Working agents must have hooks
+  // Mayors are always 'working' and intentionally have no hook — exclude them.
   const unhookedWorkers = z
     .object({ bead_id: z.string() })
     .array()
@@ -1505,6 +1506,7 @@ export function checkInvariants(sql: SqlStorage): Violation[] {
         FROM ${agent_metadata}
         WHERE ${agent_metadata.status} = 'working'
           AND ${agent_metadata.current_hook_bead_id} IS NULL
+          AND ${agent_metadata.role} != 'mayor'
       `,
         []
       ),
@@ -1516,26 +1518,27 @@ export function checkInvariants(sql: SqlStorage): Violation[] {
     });
   }
 
-  // Invariant 5: Convoy beads should not be in_progress
-  const inProgressConvoys = z
-    .object({ bead_id: z.string() })
+  // Invariant 5: Convoy beads should not be in unexpected states.
+  // Valid transient states: open, in_progress, in_review, closed.
+  const badStateConvoys = z
+    .object({ bead_id: z.string(), status: z.string() })
     .array()
     .parse([
       ...query(
         sql,
         /* sql */ `
-        SELECT ${beads.bead_id}
+        SELECT ${beads.bead_id}, ${beads.status}
         FROM ${beads}
         WHERE ${beads.type} = 'convoy'
-          AND ${beads.status} = 'in_progress'
+          AND ${beads.status} NOT IN ('open', 'in_progress', 'in_review', 'closed')
       `,
         []
       ),
     ]);
-  for (const c of inProgressConvoys) {
+  for (const c of badStateConvoys) {
     violations.push({
       invariant: 5,
-      message: `Convoy bead ${c.bead_id} is in_progress (should only be open or closed)`,
+      message: `Convoy bead ${c.bead_id} is in unexpected state '${c.status}'`,
     });
   }