verify bad pivot gets helpful error

Author: labkey-chrisj

src/org/labkey/test/tests/PivotQueryTest.java

@@ -25,6 +25,7 @@
 import org.labkey.test.categories.Daily;
 import org.labkey.test.categories.Data;
 import org.labkey.test.components.ChartTypeDialog;
+import org.labkey.test.pages.query.SourceQueryPage;
 import org.labkey.test.pages.study.DatasetDesignerPage;
 import org.labkey.test.params.FieldDefinition;
 import org.labkey.test.util.DataRegionTable;
@@ -214,10 +215,10 @@ public void testBadPivotQuery()
         importPage.setText(bulkData);
         importPage.submit();
 
-        // configure the query
+        // configure the query without F1 as pivot field
         String queryName = "Q1";
         String queryText = """
-                SELECT ParticipantId, SequenceNum, MAX([F1]) AS I1Max, [F1] FROM study.[D2]
+                SELECT ParticipantId, SequenceNum, MAX([F1]) AS I1Max FROM study.[D2]
                 GROUP BY ParticipantId, SequenceNum, [F1]
                 PIVOT I1Max BY [F1]
                 """.replace("[F1]", EscapeUtil.getSqlQuotedValue(textFieldName))
@@ -230,6 +231,22 @@ SELECT ParticipantId, SequenceNum, MAX([F1]) AS I1Max, [F1] FROM study.[D2]
         sourceQueryPage.setSource(queryText);
         sourceQueryPage.clickSaveAndFinish();
 
+        // expect query error
+        waitForText("Query 'Q1' has errors", "Error on line 3: Can not find pivot column:");
+
+        // update the query to include the pivot column and verify it works
+        String updatedQueryText = """
+                SELECT ParticipantId, SequenceNum, MAX([F1]) AS I1Max, [F1] FROM study.[D2]
+                GROUP BY ParticipantId, SequenceNum, [F1]
+                PIVOT I1Max BY [F1]
+                """.replace("[F1]", EscapeUtil.getSqlQuotedValue(textFieldName))
+                .replace("[D2]", EscapeUtil.getSqlQuotedValue(datasetName));
+
+        clickAndWait(Locator.linkWithText("Edit Query"));
+        var editQueryPage = new SourceQueryPage(getDriver());
+        editQueryPage.setSource(updatedQueryText);
+        editQueryPage.clickSaveAndFinish();
+
         // ensure query results contain F1 contents
         assertTextPresent("this", "that", "the other", "and more", "but wait", "still more");
     }