From 3b13d2a9303b51f1be48c3e9aa30a62e0dc14861 Mon Sep 17 00:00:00 2001 From: ElectricalBoy <15651807+ElectricalBoy@users.noreply.github.com> Date: Tue, 24 Feb 2026 15:24:21 +0900 Subject: [PATCH 1/6] better no result message --- lua/wikis/commons/MatchTable.lua | 12 ++++++++++-- 1 file changed, 10 insertions(+), 2 deletions(-) diff --git a/lua/wikis/commons/MatchTable.lua b/lua/wikis/commons/MatchTable.lua index a7126072e55..d314c7f67c4 100644 --- a/lua/wikis/commons/MatchTable.lua +++ b/lua/wikis/commons/MatchTable.lua @@ -568,8 +568,16 @@ function MatchTable:buildDisplay() :node(self:headerRow()) if Table.isEmpty(self.matches) then - local text = 'This ' .. (self.config.mode == Opponent.solo and Opponent.solo or Opponent.team) - .. ' has not played any matches yet.' + local isH2H = Logic.isNotEmpty(self.config.vs) + local text = String.interpolate( + '${pronoun} ${mode} ${verb} not played any matches ${explanation}yet.', + { + pronoun = isH2H and 'These' or 'This', + mode = self.config.mode == Opponent.solo and 'player' or 'team', + verb = isH2H and 'have' or 'has', + explanation = isH2H and 'against each other ' or '' + } + ) return display:tag('tr') :tag('td') From 16b50b7265455373c7d78f73086b81907622fa87 Mon Sep 17 00:00:00 2001 From: ElectricalBoy <15651807+ElectricalBoy@users.noreply.github.com> Date: Tue, 24 Feb 2026 15:29:20 +0900 Subject: [PATCH 2/6] use I18n --- lua/wikis/commons/I18n/Data.lua | 3 +++ lua/wikis/commons/MatchTable.lua | 5 +++-- 2 files changed, 6 insertions(+), 2 deletions(-) diff --git a/lua/wikis/commons/I18n/Data.lua b/lua/wikis/commons/I18n/Data.lua index 69be2411a92..9bd01131406 100644 --- a/lua/wikis/commons/I18n/Data.lua +++ b/lua/wikis/commons/I18n/Data.lua @@ -106,6 +106,9 @@ return { -- MatchSummary Map Veto ['matchsummary-mapveto-start'] = 'Start Map Veto', + -- MatchTable + ['matchtable-no-match-results'] = '${pronoun} ${mode} ${verb} not played any matches ${explanation}yet.', + -- MatchTicker ['matchticker-upcoming-matches'] = 'Upcoming Matches', diff --git a/lua/wikis/commons/MatchTable.lua b/lua/wikis/commons/MatchTable.lua index d314c7f67c4..af71f612f99 100644 --- a/lua/wikis/commons/MatchTable.lua +++ b/lua/wikis/commons/MatchTable.lua @@ -12,6 +12,7 @@ local Class = Lua.import('Module:Class') local Countdown = Lua.import('Module:Countdown') local DateExt = Lua.import('Module:Date/Ext') local Game = Lua.import('Module:Game') +local I18n = Lua.import('Module:I18n') local Info = Lua.import('Module:Info') local LeagueIcon = Lua.import('Module:LeagueIcon') local Logic = Lua.import('Module:Logic') @@ -569,8 +570,8 @@ function MatchTable:buildDisplay() if Table.isEmpty(self.matches) then local isH2H = Logic.isNotEmpty(self.config.vs) - local text = String.interpolate( - '${pronoun} ${mode} ${verb} not played any matches ${explanation}yet.', + local text = I18n.translate( + 'matchtable-no-match-results', { pronoun = isH2H and 'These' or 'This', mode = self.config.mode == Opponent.solo and 'player' or 'team', From 0418dc3dc9b88ee7653246bb2cb840476749e9b1 Mon Sep 17 00:00:00 2001 From: ElectricalBoy <15651807+ElectricalBoy@users.noreply.github.com> Date: Tue, 24 Feb 2026 15:55:33 +0900 Subject: [PATCH 3/6] update mode string Co-authored-by: hjpalpha <75081997+hjpalpha@users.noreply.github.com> --- lua/wikis/commons/MatchTable.lua | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/lua/wikis/commons/MatchTable.lua b/lua/wikis/commons/MatchTable.lua index af71f612f99..f25e28b24ab 100644 --- a/lua/wikis/commons/MatchTable.lua +++ b/lua/wikis/commons/MatchTable.lua @@ -574,7 +574,9 @@ function MatchTable:buildDisplay() 'matchtable-no-match-results', { pronoun = isH2H and 'These' or 'This', - mode = self.config.mode == Opponent.solo and 'player' or 'team', + mode = self.config.mode == Opponent.solo + and (isH2H and 'players' or 'player) + or (isH2H and'teams' or 'team), verb = isH2H and 'have' or 'has', explanation = isH2H and 'against each other ' or '' } From 97f0f80836b24382226dd2de1b21a07dd3c805c8 Mon Sep 17 00:00:00 2001 From: hjpalpha <75081997+hjpalpha@users.noreply.github.com> Date: Tue, 24 Feb 2026 07:57:00 +0100 Subject: [PATCH 4/6] please the linter --- lua/wikis/commons/MatchTable.lua | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/lua/wikis/commons/MatchTable.lua b/lua/wikis/commons/MatchTable.lua index f25e28b24ab..ee5ebd42bd7 100644 --- a/lua/wikis/commons/MatchTable.lua +++ b/lua/wikis/commons/MatchTable.lua @@ -576,7 +576,7 @@ function MatchTable:buildDisplay() pronoun = isH2H and 'These' or 'This', mode = self.config.mode == Opponent.solo and (isH2H and 'players' or 'player) - or (isH2H and'teams' or 'team), + or (isH2H and'teams' or 'team'), verb = isH2H and 'have' or 'has', explanation = isH2H and 'against each other ' or '' } From 7ed5089b25564306eb05a4092ce0d77e62073009 Mon Sep 17 00:00:00 2001 From: hjpalpha <75081997+hjpalpha@users.noreply.github.com> Date: Tue, 24 Feb 2026 07:57:24 +0100 Subject: [PATCH 5/6] linter again --- lua/wikis/commons/MatchTable.lua | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/lua/wikis/commons/MatchTable.lua b/lua/wikis/commons/MatchTable.lua index ee5ebd42bd7..4d2b454624a 100644 --- a/lua/wikis/commons/MatchTable.lua +++ b/lua/wikis/commons/MatchTable.lua @@ -575,7 +575,7 @@ function MatchTable:buildDisplay() { pronoun = isH2H and 'These' or 'This', mode = self.config.mode == Opponent.solo - and (isH2H and 'players' or 'player) + and (isH2H and 'players' or 'player') or (isH2H and'teams' or 'team'), verb = isH2H and 'have' or 'has', explanation = isH2H and 'against each other ' or '' From 236e18452b98a78d7ec3719759b82db829847b6e Mon Sep 17 00:00:00 2001 From: hjpalpha <75081997+hjpalpha@users.noreply.github.com> Date: Tue, 24 Feb 2026 07:58:00 +0100 Subject: [PATCH 6/6] missing space --- lua/wikis/commons/MatchTable.lua | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/lua/wikis/commons/MatchTable.lua b/lua/wikis/commons/MatchTable.lua index 4d2b454624a..511fd1fd044 100644 --- a/lua/wikis/commons/MatchTable.lua +++ b/lua/wikis/commons/MatchTable.lua @@ -576,7 +576,7 @@ function MatchTable:buildDisplay() pronoun = isH2H and 'These' or 'This', mode = self.config.mode == Opponent.solo and (isH2H and 'players' or 'player') - or (isH2H and'teams' or 'team'), + or (isH2H and 'teams' or 'team'), verb = isH2H and 'have' or 'has', explanation = isH2H and 'against each other ' or '' }