Skip to content

Incorrect default export #30

@rubiesonthesky

Description

@rubiesonthesky

After updating my local project to use moduleResolution: nodenext, I noticed that type checking is no longer working.

Checking with Are types wrong tool, it seems to be reporting same problem https://arethetypeswrong.github.io/?p=ssl-checker%402.0.9

Problems
❗️ Incorrect default export

  • The resolved types use export default where the JavaScript file appears to use module.exports =. This will cause TypeScript under the node16 module mode to think an extra .default property access is required, but that will likely fail at runtime. These types should use export = instead of export default.

The problem probably stems that this package has both cjs and esm output and those need little bit different type definitions 🙈

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions