Skip to content

Help window has no left padding #5040

@egmontkob

Description

@egmontkob

Is there an existing issue for this?

  • I have searched the existing issues

Midnight Commander version and build configuration

4.8.33, git

Operating system

.

Is this issue reproducible using the latest version of Midnight Commander?

  • I confirm the issue is still reproducible with the latest version of Midnight Commander

How to reproduce

The Help window has no inner padding on the left side. This results in a less pleasant look than with a bit of gap there.

It does have such a padding on the right side (not just in the screenshot but with any text), so the text flow isn't even centered.

Pretty much all the widgets do have an inner padding on the left and right sides (with the notable exception of the panels themselves).

Image

Expected behavior

.

Actual behavior

.

Additional context

Unfortunately, at the de facto standard window width of 80 columns, it just so happens that adding that padding decreases the width available for text by 1 column, and it results on the trailing dot of "contents." to be wrapped to the next line.

It's another story that the rendering engine treats a change of rendering properties as a possible breaking point, which would be nontrivial to fix, and isn't my goal here.

I think at least the help's opening page shouldn't suffer from such a rendering issue. Without spending much time on fixing the rendering engine, there are two possible solutions:

  • Eliminate "french spacing", i.e. the double spaces between sentences. This line happens to have one, it'd make up for the lost column. Many people claim that it's an outdated typesetting practice, and in the computer era it's preferable just to have a single space. It's used inconsistently, the other occurrence in this very screenshot having one space only.

  • Increase the help window's width by 2 characters (1 on each side).

Any preference? :)


Also note that while I wish to push the left edge of the text 1 cell to the right, I don't want to push the big logo alongside. The logo alignes so nicely with the dialog's corner. This big logo is now defined with a leading space in each of its lines, removing that leading space would compensate for the new left padding.

Metadata

Metadata

Assignees

No one assigned

    Labels

    area: coreIssues not related to a specific subsystemprio: lowMinor problem or easily worked around

    Type

    Projects

    No projects

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions