Learn keys: Does not escape properly when saving

[egmontkob]

Is there an existing issue for this?

• I have searched the existing issues

Midnight Commander version and build configuration

4.8.33, git

Operating system

.

Is this issue reproducible using the latest version of Midnight Commander?

• I confirm the issue is still reproducible with the latest version of Midnight Commander

How to reproduce

The bindings of escape sequences are read from the global mc.lib and local ini.

They undergo two levels of unescaping. First, GLib's KeyFile unescapes \\e (three bytes) to \e (two bytes), and \; to \.

Then our code unescapes \e (two bytes) to the escape byte, and ^X (two bytes) to the Ctrl-X byte.

When saving the entries, our own unescaping doesn't have an escaping counterpart.

A sequence ending in ^, e.g. urxvt's Ctrl+Fn, ends up being stored in the file ending in a single ^, which, when read back, is dropped as an incomplete sequence.

See also #5048: using KeyFile's get/set_value() we could probably flatten this to a single layer of escaping/unescaping.

Expected behavior

.

Actual behavior

.

Additional context

No response

[egmontkob]

I think this is a faulty bugreport.

I couldn't test the behavior because Learn keys doesn't accept urxvt's ctrl-f1 \e[11^ keypress.

I misread the source. Indeed there's no escaping when the sequence is written to the file; it's escaped when it's learned and stored in memory. (A pretty bad pattern, IMO. The real raw value should be stored in memory, not some escaped representation.)

Let me close this, my patch to #5048 will also address the internal representation, it's probably pointless to keep this as a separate issue.