updated github action to only use the new default non gpu tests

Author: jmacey

test_all.sh

@@ -3,3 +3,4 @@
 uv run pytest
 uv run pytest -m opengl
 uv run pytest -m webgpu
+uv run pytest -m qt

tests/conftest.py

@@ -9,6 +9,7 @@ def pytest_configure(config):
     """Configure pytest with custom markers."""
     config.addinivalue_line("markers", "opengl: mark test as using an OpenGL context")
     config.addinivalue_line("markers", "webgpu: mark test as using a WebGPU device")
+    config.addinivalue_line("markers", "qt: mark test as using qt for ")
 
 
 def pytest_collection_modifyitems(config, items):
@@ -27,14 +28,18 @@ def pytest_collection_modifyitems(config, items):
                 item.add_marker(pytest.mark.opengl)
             elif "webgpu_device" in fixtures:
                 item.add_marker(pytest.mark.webgpu)
+            elif "qt_app" in fixtures:
+                item.add_marker(pytest.mark.qt)
         return
 
     # If no marker is specified, manually partition the tests.
     remaining_items = []
     deselected_items = []
     for item in items:
         fixtures = getattr(item, "fixturenames", [])
-        is_graphics = "opengl_context" in fixtures or "webgpu_device" in fixtures
+
+        is_graphics = "opengl_context" in fixtures or "webgpu_device" in fixtures or "qt_app" in fixtures
+
         if is_graphics:
             deselected_items.append(item)
         else:
@@ -46,6 +51,10 @@ def pytest_collection_modifyitems(config, items):
         config.hook.pytest_deselected(items=deselected_items)
 
 
+@pytest.fixture(scope="session")
+def qt_app(): ...
+
+
 @pytest.fixture(scope="session")
 def opengl_context():
     if not glfw.init():

tests/test_lookat_widget.py

@@ -2,11 +2,12 @@
 from PySide6.QtCore import Qt
 from PySide6.QtTest import QTest
 from PySide6.QtWidgets import QFrame, QVBoxLayout
+
 from ncca.ngl import Mat4, Vec3, look_at
 from ncca.ngl.widgets import LookAtWidget
 
 
-def test_lookatwidget_initial_value(qtbot):
+def test_lookatwidget_initial_value(qt_app, qtbot):
     """Test default initialization values."""
     widget = LookAtWidget()
     qtbot.addWidget(widget)
@@ -18,7 +19,7 @@ def test_lookatwidget_initial_value(qtbot):
     assert widget.get_name() == ""
 
 
-def test_lookatwidget_constructor_with_parameters(qtbot):
+def test_lookatwidget_constructor_with_parameters(qt_app, qtbot):
     """Test initialization with custom parameters."""
     eye = Vec3(5, 5, 5)
     look = Vec3(1, 1, 1)
@@ -33,7 +34,7 @@ def test_lookatwidget_constructor_with_parameters(qtbot):
     assert widget._toggle_button.text() == name
 
 
-def test_set_eye(qtbot):
+def test_set_eye(qt_app, qtbot):
     """Test setting the eye position."""
     widget = LookAtWidget()
     qtbot.addWidget(widget)
@@ -44,7 +45,7 @@ def test_set_eye(qtbot):
     assert widget.get_eye() == new_eye
 
 
-def test_set_look(qtbot):
+def test_set_look(qt_app, qtbot):
     """Test setting the look-at position."""
     widget = LookAtWidget()
     qtbot.addWidget(widget)
@@ -55,7 +56,7 @@ def test_set_look(qtbot):
     assert widget.get_look() == new_look
 
 
-def test_set_up(qtbot):
+def test_set_up(qt_app, qtbot):
     """Test setting the up vector via index."""
     widget = LookAtWidget()
     qtbot.addWidget(widget)
@@ -73,7 +74,7 @@ def test_set_up(qtbot):
     assert widget.get_up() == Vec3(0, 0, 1)
 
 
-def test_set_name(qtbot):
+def test_set_name(qt_app, qtbot):
     """Test setting the widget name."""
     widget = LookAtWidget()
     qtbot.addWidget(widget)
@@ -85,7 +86,7 @@ def test_set_name(qtbot):
     assert widget._toggle_button.text() == new_name
 
 
-def test_property_accessors(qtbot):
+def test_property_accessors(qt_app, qtbot):
     """Test Qt Property wrappers."""
     widget = LookAtWidget()
     qtbot.addWidget(widget)
@@ -103,7 +104,7 @@ def test_property_accessors(qtbot):
     assert widget.get_name() == "PropertyCamera"
 
 
-def test_value_changed_signal_on_eye_change(qtbot):
+def test_value_changed_signal_on_eye_change(qt_app, qtbot):
     """Test that valueChanged signal emits when eye position changes."""
     widget = LookAtWidget()
     qtbot.addWidget(widget)
@@ -115,7 +116,7 @@ def test_value_changed_signal_on_eye_change(qtbot):
     assert isinstance(signal.args[0], Mat4)
 
 
-def test_value_changed_signal_on_look_change(qtbot):
+def test_value_changed_signal_on_look_change(qt_app, qtbot):
     """Test that valueChanged signal emits when look position changes."""
     widget = LookAtWidget()
     qtbot.addWidget(widget)
@@ -127,7 +128,7 @@ def test_value_changed_signal_on_look_change(qtbot):
     assert isinstance(signal.args[0], Mat4)
 
 
-def test_value_changed_signal_on_up_change(qtbot):
+def test_value_changed_signal_on_up_change(qt_app, qtbot):
     """Test that valueChanged signal emits when up vector changes."""
     widget = LookAtWidget()
     qtbot.addWidget(widget)
@@ -139,7 +140,7 @@ def test_value_changed_signal_on_up_change(qtbot):
     assert isinstance(signal.args[0], Mat4)
 
 
-def test_view_matrix_calculation(qtbot):
+def test_view_matrix_calculation(qt_app, qtbot):
     """Test that the view matrix is calculated correctly."""
     eye = Vec3(0, 0, 5)
     look = Vec3(0, 0, 0)
@@ -160,7 +161,7 @@ def test_view_matrix_calculation(qtbot):
             assert view_matrix[i][j] == pytest.approx(expected_matrix[i][j])
 
 
-def test_view_matrix_updates_on_parameter_change(qtbot):
+def test_view_matrix_updates_on_parameter_change(qt_app, qtbot):
     """Test that view matrix updates when parameters change."""
     widget = LookAtWidget()
     qtbot.addWidget(widget)
@@ -176,7 +177,7 @@ def test_view_matrix_updates_on_parameter_change(qtbot):
     assert initial_view != updated_view
 
 
-def test_toggle_collapsed_expand(qtbot):
+def test_toggle_collapsed_expand(qt_app, qtbot):
     """Test expanding the collapsible section."""
     widget = LookAtWidget()
     qtbot.addWidget(widget)
@@ -189,7 +190,7 @@ def test_toggle_collapsed_expand(qtbot):
     assert widget._toggle_button.arrowType() == Qt.ArrowType.DownArrow
 
 
-def test_toggle_collapsed_collapse(qtbot):
+def test_toggle_collapsed_collapse(qt_app, qtbot):
     """Test collapsing the collapsible section."""
     widget = LookAtWidget()
     qtbot.addWidget(widget)
@@ -202,7 +203,7 @@ def test_toggle_collapsed_collapse(qtbot):
     assert widget._toggle_button.arrowType() == Qt.ArrowType.RightArrow
 
 
-def test_toggle_collapsed_toggle_sequence(qtbot):
+def test_toggle_collapsed_toggle_sequence(qt_app, qtbot):
     """Test toggling between collapsed and expanded states."""
     widget = LookAtWidget()
     qtbot.addWidget(widget)
@@ -221,7 +222,7 @@ def test_toggle_collapsed_toggle_sequence(qtbot):
     assert widget._content_widget.isVisible()
 
 
-def test_world_up_vectors(qtbot):
+def test_world_up_vectors(qt_app, qtbot):
     """Test that world_up class variable contains correct vectors."""
     widget = LookAtWidget()
     qtbot.addWidget(widget)
@@ -231,7 +232,7 @@ def test_world_up_vectors(qtbot):
     assert LookAtWidget.world_up[2] == Vec3(0, 0, 1)  # z-up
 
 
-def test_combobox_items(qtbot):
+def test_combobox_items(qt_app, qtbot):
     """Test that the up vector combobox has correct items."""
     widget = LookAtWidget()
     qtbot.addWidget(widget)
@@ -242,7 +243,7 @@ def test_combobox_items(qtbot):
     assert widget._up.itemText(2) == "z-up"
 
 
-def test_matrix_recalculation_with_different_up_vectors(qtbot):
+def test_matrix_recalculation_with_different_up_vectors(qt_app, qtbot):
     """Test that changing up vector produces different view matrices."""
     widget = LookAtWidget(eye=Vec3(5, 5, 5), look=Vec3(0, 0, 0))
     qtbot.addWidget(widget)
@@ -265,7 +266,7 @@ def test_matrix_recalculation_with_different_up_vectors(qtbot):
     assert matrix_x_up != matrix_z_up
 
 
-def test_multiple_value_changed_emissions(qtbot):
+def test_multiple_value_changed_emissions(qt_app, qtbot):
     """Test that multiple changes emit multiple signals."""
     widget = LookAtWidget()
     qtbot.addWidget(widget)

tests/test_pyside_event_handling_mixin.py

@@ -5,7 +5,7 @@
 and camera state management functionality.
 """
 
-from unittest.mock import Mock, patch
+from unittest.mock import MagicMock, Mock
 
 import pytest
 from PySide6.QtCore import QPointF, Qt
@@ -30,7 +30,7 @@ def close(self) -> None:
 
 
 @pytest.fixture
-def event_window():
+def event_window(qt_app):
     """Create a test window with event handling"""
     window = MockEventHandlingWindow()
     window.setup_event_handling()
@@ -53,7 +53,7 @@ def test_setup_event_handling_default_values(event_window):
     assert event_window.zoom_sensitivity == PySideEventHandlingMixin.DEFAULT_ZOOM_SENSITIVITY
 
 
-def test_setup_event_handling_custom_values():
+def test_setup_event_handling_custom_values(qt_app):
     """Test setup_event_handling with custom parameters"""
     window = MockEventHandlingWindow()
     initial_pos = Vec3(1, 2, 3)
@@ -104,24 +104,29 @@ def test_key_press_event_escape(event_window):
     assert event_window.update_called is True
 
 
-@patch("OpenGL.GL.glPolygonMode")
-def test_key_press_event_wireframe_mode(mock_gl_polygon_mode, event_window):
+def test_key_press_event_wireframe_mode(event_window, monkeypatch):
     """Test W key switches to wireframe mode"""
     event = Mock()
     event.key.return_value = Qt.Key_W
 
+    mock_gl_polygon_mode = MagicMock()
+    # Use fixture-provided monkeypatch to set attribute (non-raising to avoid import issues)
+    monkeypatch.setattr("OpenGL.GL.glPolygonMode", mock_gl_polygon_mode, raising=False)
+
     event_window.keyPressEvent(event)
 
     mock_gl_polygon_mode.assert_called_once()
     assert event_window.update_called is True
 
 
-@patch("OpenGL.GL.glPolygonMode")
-def test_key_press_event_solid_mode(mock_gl_polygon_mode, event_window):
+def test_key_press_event_solid_mode(event_window, monkeypatch):
     """Test S key switches to solid fill mode"""
     event = Mock()
     event.key.return_value = Qt.Key_S
 
+    mock_gl_polygon_mode = MagicMock()
+    monkeypatch.setattr("OpenGL.GL.glPolygonMode", mock_gl_polygon_mode, raising=False)
+
     event_window.keyPressEvent(event)
 
     mock_gl_polygon_mode.assert_called_once()
@@ -146,19 +151,18 @@ def test_key_press_event_space_reset(event_window):
     assert event_window.update_called is True
 
 
-def test_key_press_event_other_key(event_window):
+def test_key_press_event_other_key(event_window, monkeypatch):
     """Test other keys call parent keyPressEvent"""
     event = Mock()
     event.key.return_value = Qt.Key_A
 
-    # Mock super() call
-    with patch("builtins.super") as mock_super:
-        mock_parent = Mock()
-        mock_super.return_value = mock_parent
+    # Mock super() call by temporarily replacing builtins.super via monkeypatch
+    mock_parent = Mock()
+    monkeypatch.setattr("builtins.super", lambda *args, **kwargs: mock_parent, raising=False)
 
-        event_window.keyPressEvent(event)
+    event_window.keyPressEvent(event)
 
-        mock_parent.keyPressEvent.assert_called_once_with(event)
+    mock_parent.keyPressEvent.assert_called_once_with(event)
 
 
 def test_mouse_press_event_left_button(event_window):
@@ -337,14 +341,14 @@ def test_wheel_event_zero_delta(event_window):
     assert event_window.update_called is True
 
 
-def test_constants():
+def test_constants(qt_app):
     """Test default sensitivity constants"""
     assert PySideEventHandlingMixin.DEFAULT_ROTATION_SENSITIVITY == pytest.approx(0.5)
     assert PySideEventHandlingMixin.DEFAULT_TRANSLATION_SENSITIVITY == pytest.approx(0.01)
     assert PySideEventHandlingMixin.DEFAULT_ZOOM_SENSITIVITY == pytest.approx(0.1)
 
 
-def test_mouse_movement_rotation_with_different_sensitivity():
+def test_mouse_movement_rotation_with_different_sensitivity(qt_app):
     """Test mouse rotation with different sensitivity values"""
     window = MockEventHandlingWindow()
     window.setup_event_handling(rotation_sensitivity=2.0)
@@ -366,7 +370,7 @@ def test_mouse_movement_rotation_with_different_sensitivity():
     assert window.spin_y_face == 20
 
 
-def test_mouse_movement_translation_with_different_sensitivity():
+def test_mouse_movement_translation_with_different_sensitivity(qt_app):
     """Test mouse translation with different sensitivity values"""
     window = MockEventHandlingWindow()
     window.setup_event_handling(translation_sensitivity=0.5)
@@ -388,7 +392,7 @@ def test_mouse_movement_translation_with_different_sensitivity():
     assert window.model_position.y == pytest.approx(10.0)
 
 
-def test_event_handling_target_protocol():
+def test_event_handling_target_protocol(qt_app):
     """Test that the protocol is properly defined"""
 
     # This should not raise any errors