Merge pull request #22 from NextStepFinalProject/NXD-24

Nxd 24 - Show Error Reason When Uploading A Resume

Author: taljacob2

nextstep-backend/src/controllers/resources_controller.ts

@@ -58,7 +58,7 @@ const createResumeResource = async (req: Request, res: Response) => {
         return res.status(201).send(resumeFilename);
     } catch (error) {
         if (error instanceof multer.MulterError || error instanceof TypeError) {
-            return res.status(400).send(error.message);
+            return res.status(400).send({ message: error.message });
         } else {
             handleError(error, res);
         }

nextstep-backend/src/openapi/swagger.yaml

@@ -836,14 +836,24 @@ paths:
         '400':
           description: Bad request
           content:
-            text/plain:
+            application/json:
+              schema:
+                type: object
+                properties:
+                  message:
+                    type: string
+                    description: Error message indicating the specific issue
+                    example: "File too large"
               examples:
                 fileTooLarge:
-                  value: "File too large"
+                  value:
+                    message: "File too large"
                 invalidFileType:
-                  value: "Invalid file type. Only PDF, DOC, DOCX and TXT/TEXT files are allowed"
+                  value:
+                    message: "Invalid file type. Only PDF, DOC, DOCX and TXT/TEXT files are allowed"
                 noFileUploaded:
-                  value: "No file uploaded"
+                  value:
+                    message: "No file uploaded"
         '401':
           description: Unauthorized
         '500':

nextstep-backend/src/tests/resources_resumes.test.ts

@@ -143,7 +143,7 @@ describe('Resume API Tests', () => {
                 .attach('file', Buffer.from('invalid content'), { filename: 'test.png' })
                 .expect(400);
 
-            expect(response.text).toBe('Invalid file type. Only PDF, DOC, DOCX and TXT/TEXT files are allowed.');
+            expect(response.text).toBe(`{"message":"Invalid file type. Only PDF, DOC, DOCX and TXT/TEXT files are allowed."}`);
         });
 
         it('should handle missing file', async () => {
@@ -152,7 +152,7 @@ describe('Resume API Tests', () => {
                 .set('Authorization', `Bearer ${testToken}`)
                 .expect(400);
 
-            expect(response.text).toBe('No file uploaded.');
+            expect(response.text).toBe(`{"message":"No file uploaded."}`);
         });
     });
 

nextstep-frontend/src/pages/Resume.tsx

@@ -285,8 +285,14 @@ const Resume: React.FC = () => {
         setLoading(false);
       };
 
-    } catch (err) {
-      setError(err instanceof Error ? err.message : 'An error occurred');
+    } catch (err: any) {
+      if (err.response && err.response.status === 400 &&
+          err.response.data && err.response.data &&
+          err.response.data.message) {
+        setError(err.response.data.message);
+      } else {
+        setError(err instanceof Error ? err.message : 'An error occurred');
+      }
       setLoading(false);
     }
   };