Skip to content

FreeDNS certbot plugin back to version 0.1.0 #5418

@VincentKirsch

Description

@VincentKirsch

Checklist

  • Have you pulled and found the error with jc21/nginx-proxy-manager:latest docker image?
    • Yes
  • Are you sure you're not using someone else's docker image?
    • Yes
  • Have you searched for similar issues (both open and closed)?
    • Yes

Describe the bug
In the backend/certbot/dns-plugins.json, the version is set 0.1.0, which causes problems as it's looking for a ttl field that is not provided for free subscribers.

A patch had been provided about a year ago (https://github.com/NginxProxyManager/nginx-proxy-manager/pull/3750/files#diff-460b85a8109d0faeea45e159d9577439a89ee230186a4c525bdec4dd589c1040) to set the version to 0.2.0 - but apparently it was reverted somehow in the latest NPM version.

Nginx Proxy Manager Version
2.14.0

To Reproduce
Try to add a certificate for a FreeDNS subdomain name; the interface provides a not so helpful "Internal error" message. The logs reveal

File "/opt/certbot/lib/python3.11/site-packages/certbot_dns_freedns/dns_freedns.py", line 286, in _load_txt_record input_ttl = soup.find("input", recursive=True, attrs={"name": "ttl"}).get("value") ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ AttributeError: 'NoneType' object has no attribute 'get'

Expected behavior
No error should be present; it used to work in December last year - unfortunately, I can't remember which version of NPM I was using.

Metadata

Metadata

Assignees

No one assigned

    Labels

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions