From a87229aa6ac57f96094022d837fb773625d8a25e Mon Sep 17 00:00:00 2001 From: Matt Simerson Date: Sat, 14 Mar 2026 21:40:45 -0700 Subject: [PATCH 1/5] doc(CONTRIBUTORS): updated --- .release | 2 +- CONTRIBUTORS.md | 4 ++-- 2 files changed, 3 insertions(+), 3 deletions(-) diff --git a/.release b/.release index d106d83..03a6c1a 160000 --- a/.release +++ b/.release @@ -1 +1 @@ -Subproject commit d106d83e69d5d8c99e4d6be4ba98ddde550d082b +Subproject commit 03a6c1ae3688bb05c658a775ec5d66086aa18bba diff --git a/CONTRIBUTORS.md b/CONTRIBUTORS.md index f3b0392..cde7ca9 100644 --- a/CONTRIBUTORS.md +++ b/CONTRIBUTORS.md @@ -2,8 +2,8 @@ This handcrafted artisanal software is brought to you by: -|
msimerson (22) | -| :----------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------: | +|
msimerson (23)| +| :---: | this file is generated by [.release](https://github.com/msimerson/.release). Contribute to this project to get your GitHub profile included here. From 46a8754dd2ee96ec233747045676a23583cb2f30 Mon Sep 17 00:00:00 2001 From: Matt Simerson Date: Sat, 14 Mar 2026 21:46:10 -0700 Subject: [PATCH 2/5] zone: disable name validate for now --- .github/workflows/ci.yml | 1 - CHANGELOG.md | 7 +++++++ lib/zone.js | 5 ++++- package.json | 2 +- 4 files changed, 12 insertions(+), 3 deletions(-) diff --git a/.github/workflows/ci.yml b/.github/workflows/ci.yml index aaf3312..6382271 100644 --- a/.github/workflows/ci.yml +++ b/.github/workflows/ci.yml @@ -16,6 +16,5 @@ jobs: secrets: inherit test: - needs: lint uses: NicTool/.github/.github/workflows/test.yml@main secrets: inherit diff --git a/CHANGELOG.md b/CHANGELOG.md index d7a2efc..41231a5 100644 --- a/CHANGELOG.md +++ b/CHANGELOG.md @@ -6,6 +6,11 @@ The format is based on [Keep a Changelog](https://keepachangelog.com/). ### Unreleased +### [0.8.4] - 2026-03-14 + +- disable domain validation, until joi.string.domain supports / + - related: hapijs/address#48 + ### [0.8.3] - 2026-03-13 - ns: NSD -> nsd @@ -97,3 +102,5 @@ The format is based on [Keep a Changelog](https://keepachangelog.com/). [0.8.1]: https://github.com/NicTool/validate/releases/tag/v0.8.1 [0.8.2]: https://github.com/NicTool/validate/releases/tag/v0.8.2 [0.8.3]: https://github.com/NicTool/validate/releases/tag/v0.8.3 +[0.8.4]: https://github.com/NicTool/validate/releases/tag/v0.8.4 +[1.0.0]: https://github.com/NicTool/validate/releases/tag/1.0.0 diff --git a/lib/zone.js b/lib/zone.js index c1bd6ee..9a5702a 100644 --- a/lib/zone.js +++ b/lib/zone.js @@ -4,7 +4,10 @@ const shared = require('./shared') exports.id = shared.uint32 -exports.zone = Joi.string().min(3).max(255).domain({ allowFullyQualified: true, tlds: false }) +exports.zone = Joi.string() + .min(3) + .max(255) + // .domain({ allowFullyQualified: true, allowUnderscore: true, tlds: false }) exports.v3 = Joi.object({ id: exports.id, diff --git a/package.json b/package.json index 234913a..8fc2107 100644 --- a/package.json +++ b/package.json @@ -1,6 +1,6 @@ { "name": "@nictool/validate", - "version": "0.8.3", + "version": "0.8.4", "description": "NicTool Object Validation", "files": [ "lib", From 63d4d56c10f3057d949ae646989954729cb59547 Mon Sep 17 00:00:00 2001 From: Matt Simerson Date: Sat, 14 Mar 2026 21:46:14 -0700 Subject: [PATCH 3/5] chore: format --- CONTRIBUTORS.md | 4 ++-- lib/zone.js | 6 ++---- package.json | 2 +- 3 files changed, 5 insertions(+), 7 deletions(-) diff --git a/CONTRIBUTORS.md b/CONTRIBUTORS.md index cde7ca9..c2e6fcf 100644 --- a/CONTRIBUTORS.md +++ b/CONTRIBUTORS.md @@ -2,8 +2,8 @@ This handcrafted artisanal software is brought to you by: -|
msimerson (23)| -| :---: | +|
msimerson (23) | +| :----------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------: | this file is generated by [.release](https://github.com/msimerson/.release). Contribute to this project to get your GitHub profile included here. diff --git a/lib/zone.js b/lib/zone.js index 9a5702a..84d63a5 100644 --- a/lib/zone.js +++ b/lib/zone.js @@ -4,10 +4,8 @@ const shared = require('./shared') exports.id = shared.uint32 -exports.zone = Joi.string() - .min(3) - .max(255) - // .domain({ allowFullyQualified: true, allowUnderscore: true, tlds: false }) +exports.zone = Joi.string().min(3).max(255) +// .domain({ allowFullyQualified: true, allowUnderscore: true, tlds: false }) exports.v3 = Joi.object({ id: exports.id, diff --git a/package.json b/package.json index 8fc2107..5adeada 100644 --- a/package.json +++ b/package.json @@ -66,4 +66,4 @@ "trailingComma": "all", "printWidth": 100 } -} \ No newline at end of file +} From fbb1a5900284882168a78714b7c04c847bc469ad Mon Sep 17 00:00:00 2001 From: Matt Simerson Date: Sat, 14 Mar 2026 21:47:37 -0700 Subject: [PATCH 4/5] update changes --- CHANGELOG.md | 1 - 1 file changed, 1 deletion(-) diff --git a/CHANGELOG.md b/CHANGELOG.md index 41231a5..25e626e 100644 --- a/CHANGELOG.md +++ b/CHANGELOG.md @@ -103,4 +103,3 @@ The format is based on [Keep a Changelog](https://keepachangelog.com/). [0.8.2]: https://github.com/NicTool/validate/releases/tag/v0.8.2 [0.8.3]: https://github.com/NicTool/validate/releases/tag/v0.8.3 [0.8.4]: https://github.com/NicTool/validate/releases/tag/v0.8.4 -[1.0.0]: https://github.com/NicTool/validate/releases/tag/1.0.0 From aeea1a921bb30268885a695e020d34c063418c65 Mon Sep 17 00:00:00 2001 From: Matt Simerson Date: Sat, 14 Mar 2026 21:49:36 -0700 Subject: [PATCH 5/5] disable zone validity tests --- lib/zone.test.js | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/lib/zone.test.js b/lib/zone.test.js index 6307cd2..61567a2 100644 --- a/lib/zone.test.js +++ b/lib/zone.test.js @@ -30,7 +30,7 @@ describe('zone', function () { .map((a) => `thisis${a}atest.com.`) for (const char of invalid_chars) { - it(`rejects invalid: ${char}`, () => { + it.skip(`rejects invalid: ${char}`, () => { const testCase = JSON.parse(JSON.stringify(testZone)) testCase.zone = char