Fix: os2forms_forloeb: Send Maestro notification handler exception handling when sending digital post

[jekuaitk]

The Maestro notification handler gives succesful result even when an exception has occurred during Digital Post.

Processing is done via the Maestro helper

public function processJob(Job $job): JobResult {
    …
    $this->sendNotification($notificationType, $submission, $templateTask, $maestroQueueID);

    return JobResult::success();
  }

private function sendNotification(…) {
   …
   try {
        …
   }
   catch (\Exception $exception) {
      $this->error('Error sending notification: @message', $context + [
        '@message' => $exception->getMessage(),
        'handler_id' => 'os2forms_forloeb',
        'operation' => 'notification failed',
        'exception' => $exception,
      ]);
    }
}

Here an exception is caught and relevant logging is done. However, since the exception is not re-thrown, the job will end up being given the result success.

[jekuaitk]

Hi @ds-bellcom

This is one of the issues we would like a review on!

[ds-bellcom]

Estimate: 1h (the review is done)!

[ds-bellcom]

@jekuaitk Review is done (3 weeks ago). Will you merge it and close this issue when done?

CC: @Anna-itk @ChatBotBerg