Skip to content

Remove dead if sequence is None check and fix impossible test mocks in test_package.py #15

@Devguru-codes

Description

@Devguru-codes

Location

  • package/src/pyaslreport/main.py:34-35
  • package/src/pyaslreport/tests/test_package.py:27,36

Description

get_sequence() in factory.py never returns None — it raises ValueError on failure for all code paths. The if sequence is None check in main.py is dead code. Two tests (test_get_bids_metadata_no_sequence and test_get_bids_metadata_invalid_modality) mock get_sequence to return None, testing an impossible scenario that doesn't reflect actual execution behavior.

Reproduction (on main branch)

Automated Results on main branch

# Test Status Detail
1 get_sequence can return None FAIL Never returns None, always raises ValueError
2 main.py has dead if sequence is None check FAIL Dead code present
3 Tests mock get_sequence with return_value=None FAIL Impossible mock scenario present

Summary: PASSED=0 FAILED=3

Making PR on this.

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions