While looking at misc_tools_parser.py (under external_project_parsers), I noticed a few small issues that could be cleaned up:
- It imports
boolean from xmlrpc.client and uses it for dry_run. This seems unnecessary — using the built-in bool would be more standard.
- The parser name has a typo:
"miscelaneous tools" → "miscellaneous tools".
- Logging is a bit inconsistent — both
logging.error(...) and logger.error(...) are used.
None of these are major issues on their own, but cleaning them up would make the code more consistent and easier to maintain.
I can take care of fixing these (and optionally add a small test if useful).
I came across this while exploring the codebase during my GSoC preparation — happy to work on it if this looks good .
While looking at
misc_tools_parser.py(underexternal_project_parsers), I noticed a few small issues that could be cleaned up:booleanfromxmlrpc.clientand uses it fordry_run. This seems unnecessary — using the built-inboolwould be more standard."miscelaneous tools"→"miscellaneous tools".logging.error(...)andlogger.error(...)are used.None of these are major issues on their own, but cleaning them up would make the code more consistent and easier to maintain.
I can take care of fixing these (and optionally add a small test if useful).
I came across this while exploring the codebase during my GSoC preparation — happy to work on it if this looks good .